Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wtoPrintf3 to use va_list #407

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

ifakhrutdinov
Copy link
Contributor

@ifakhrutdinov ifakhrutdinov commented Oct 11, 2023

Proposed changes

Based on the way wtoPrintf3 is used, it should have been coded with va_list instead of varargs.

Since this function has just been introduced, and considering the severity, a breaking change should be fine.

This PR addresses Issue: #406

This PR depends upon the following PRs: N/A

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

WTO messages must be verified in:

  • ZIS
  • ZSS
  • Launcher

Further comments

Based on the way wtoPrintf3 is used, it should
have been coded with va_list instead of varargs.

Since this function has just been introduced,
and considering the severity, a breaking change
should be fine.

Fixes: #406

Signed-off-by: Irek Fakhrutdinov <[email protected]>
@ifakhrutdinov ifakhrutdinov self-assigned this Oct 11, 2023
@ifakhrutdinov ifakhrutdinov requested a review from JoeNemo October 11, 2023 16:20
@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Oct 12, 2023
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks for fixing.

@JoeNemo JoeNemo merged commit 4b3aa89 into v2.x/staging Oct 12, 2023
5 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/fix-wtoPrintf3 branch October 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants