Initial prototype implementation #8

msujew · 2024-09-04T12:12:15Z

This is an initial implementation of the PL/I language server using Langium. It supports most (as far as we can tell) of the base language. Missing prominent features:

Macro language (preprocessor)
Compiler flags

packages/extension/src/extension/builtin-files.ts

packages/language/src/documentation.ts/pli-documentation-provider.ts

packages/language/src/parser/pli-grammar.ts

scripts/merge-tmlanguage.mjs

asatklichov

Code is nice 👍, now will check tests and do some testing

asatklichov · 2024-09-05T08:17:41Z

package.json

@@ -0,0 +1,34 @@
+{


Just note: Some versions seems older, seen by npm outdated, and npm install shows some 'moderate severity vulnerability' but build becomes OK once I run npm update

asatklichov · 2024-09-05T08:38:19Z

packages/extension/src/extension/builtin-files.ts

+        };
+    }
+
+    readFile(uri: vscode.Uri): Uint8Array {


unused 'uri' but can be replaced with _uri, same for stat()

packages/language/src/parser/pli-lexer.ts

asatklichov · 2024-09-05T09:18:16Z

vitest.config.ts

+        deps: {
+            interopDefault: true
+        },
+        include: ['packages/**/test/**/*.test.ts']


Can we set some basic coverageThreshold in vitest config? Build automatically fails if coverage drops down, simple and helpful during dev.
Like in Jest e.g.:
thresholds: {
lines: 80,
functions: 80,
branches: 80,
statements: 80
}

I would strongly advise against that because it won't help with the quality and will create a number of undesired side effects.

This is common practice. Side effect only happens in code change not in test, this is just a test coverage measurement. Same measures tuned in sonar or Jenkins upon project.

KUGDev · 2024-09-06T10:52:38Z

LGTM, works the same way in IntelliJ IDEA

VitGottwald · 2024-09-09T09:20:00Z

Please, add .nvmrc file with expected node version (e.g. v20.17.0).

packages/language/src/pli.langium

VitGottwald · 2024-09-17T06:54:06Z

packages/extension/.vscodeignore

+.vscode/**
+.vscode-test/**
+src/**


How about explicitly only including what is needed? package.json and README.md are included automatically.

Suggested change

.vscode/**

.vscode-test/**

src/**

# Ignore everything

*

**/*

../**/* # when `vsce` run with `--no-dependencies` this is not needed

../../**/* # when `vsce` run with `--no-dependencies` this is not needed

# Add what we actually want

!out/extension/main.cjs

!out/extension/main.cjs.map

!language-configuration.json

!syntaxes/pli.merged.json

.vscode/launch.json

VitGottwald · 2024-09-17T11:26:39Z

Can we replace pl-one everywhere in the code and package.json(s) with pli to have single word language name like we do for the other extensions (hlasm, cobol, rexx, jcl, ...)?

code_samples/CHART.pli

code_samples/MACROS.pli

code_samples/PLI0002.pli

packages/extension/package.json

asatklichov · 2024-10-09T13:00:38Z

adding CI build, vsix gen, and browser exec
dummy validation and semantic class

azatsatklichov · 2024-11-20T13:37:24Z

packages/extension/README.md

Let's leave an empty line - MD047

azatsatklichov · 2024-11-20T13:52:25Z

packages/language/README.md

New EOL character MD047

KUGDev · 2024-11-21T12:18:45Z

From the repo perspective, it would be better to separate the actual solution between different folders. The implementation is intended to be supported both in VS Code and IntelliJ IDEA. Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future

azatsatklichov · 2024-11-21T12:39:38Z

From the repo perspective, it would be better to separate the actual solution between different folders. The implementation is intended to be supported both in VS Code and IntelliJ IDEA. Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future

It is a good idea, I agree.

msujew · 2024-11-21T14:01:24Z

Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future

@KUGDev I agree, that's why all the VS Code related parts already are part of the packages/extension directory. Are there any specific parts we've missed?

KUGDev · 2024-11-21T14:10:13Z

@msujew ok I see. Then the IntelliJ IDEA related stuff will go into the "packages" folder as well. Will the "extension" folder remain with the same name? Cause if we add the "plugin" folder, it would mean that we are going to provide IntelliJ IDEA plugin only. I guess, the "intellij-plugin" naming would be more appropriate, and to stay consistent, it would mean that for the VSCode extension the folder name "vscode-extension" would be more appropriate as well

.vscode/launch.json

.github/workflows/ci.yml

azatsatklichov

💯

VitGottwald · 2024-12-04T11:36:58Z

package.json

+    },
+    "volta": {
+        "node": "18.20.3",
+        "npm": "10.7.0"


What about pnpm, can Volta manage it as well?

Also how about having an .nvmrc file? I think it is more common than Volta. In addition to nvm it is also supported by fnm which I have been successfully using and very happy with for years.

I believe our yeoman generator automatically adds the volta entry. I can add a .nvmrc file instead 👍

Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/extension/src/extension/builtin-files.ts Outdated Show resolved Hide resolved

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/language/src/documentation.ts/pli-documentation-provider.ts Show resolved Hide resolved

KUGDev reviewed Sep 4, 2024

View reviewed changes

packages/language/src/parser/pli-grammar.ts Outdated Show resolved Hide resolved

scripts/merge-tmlanguage.mjs Outdated Show resolved Hide resolved

asatklichov self-assigned this Sep 4, 2024

msujew force-pushed the feature/langium-project branch from b06d804 to 9b0ecae Compare September 4, 2024 13:03

asatklichov reviewed Sep 5, 2024

View reviewed changes

KUGDev self-requested a review September 5, 2024 18:36

KUGDev approved these changes Sep 6, 2024

View reviewed changes

asatklichov reviewed Sep 12, 2024

View reviewed changes

packages/language/src/pli.langium Outdated Show resolved Hide resolved

VitGottwald reviewed Sep 17, 2024

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/CHART.pli Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/MACROS.pli Outdated Show resolved Hide resolved

VAranouski reviewed Sep 17, 2024

View reviewed changes

code_samples/PLI0002.pli Outdated Show resolved Hide resolved

VitGottwald reviewed Sep 18, 2024

View reviewed changes

packages/extension/package.json Outdated Show resolved Hide resolved

msujew force-pushed the feature/langium-project branch 7 times, most recently from 8aa2a54 to a6e1b12 Compare November 18, 2024 13:20

azatsatklichov reviewed Nov 20, 2024

View reviewed changes

KUGDev self-requested a review November 21, 2024 12:14

msujew force-pushed the feature/langium-project branch 2 times, most recently from cfe3f94 to d5bf1a6 Compare November 21, 2024 16:23

KUGDev reviewed Nov 22, 2024

View reviewed changes

.vscode/launch.json Show resolved Hide resolved

KUGDev reviewed Nov 22, 2024

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

azatsatklichov approved these changes Nov 26, 2024

View reviewed changes

msujew force-pushed the feature/langium-project branch 2 times, most recently from 1f0d1c2 to cfcd5bf Compare November 26, 2024 17:37

VitGottwald reviewed Dec 4, 2024

View reviewed changes

Prototype implementation of PL/I

6b5d434

Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>

msujew force-pushed the feature/langium-project branch from cfcd5bf to 6b5d434 Compare December 11, 2024 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial prototype implementation #8

Initial prototype implementation #8

msujew commented Sep 4, 2024

asatklichov left a comment

asatklichov Sep 5, 2024 •

edited

Loading

asatklichov Sep 5, 2024

asatklichov Sep 5, 2024 •

edited

Loading

VitGottwald Sep 9, 2024

asatklichov Sep 9, 2024

KUGDev commented Sep 6, 2024

VitGottwald commented Sep 9, 2024

VitGottwald Sep 17, 2024

VitGottwald commented Sep 17, 2024

asatklichov commented Oct 9, 2024

azatsatklichov Nov 20, 2024

azatsatklichov Nov 20, 2024

KUGDev commented Nov 21, 2024

azatsatklichov commented Nov 21, 2024

msujew commented Nov 21, 2024 •

edited

Loading

KUGDev commented Nov 21, 2024

azatsatklichov left a comment

VitGottwald Dec 4, 2024

msujew Dec 4, 2024

-.vscode/**
-.vscode-test/**
-src/**
+# Ignore everything
+*
+**/*
+../**/*     # when `vsce` run with `--no-dependencies` this is not needed
+../../**/*  # when `vsce` run with `--no-dependencies` this is not needed
+# Add what we actually want
+!out/extension/main.cjs
+!out/extension/main.cjs.map
+!language-configuration.json
+!syntaxes/pli.merged.json

Initial prototype implementation #8

Are you sure you want to change the base?

Initial prototype implementation #8

Conversation

msujew commented Sep 4, 2024

asatklichov left a comment

Choose a reason for hiding this comment

asatklichov Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asatklichov Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KUGDev commented Sep 6, 2024

VitGottwald commented Sep 9, 2024

Choose a reason for hiding this comment

VitGottwald commented Sep 17, 2024

asatklichov commented Oct 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KUGDev commented Nov 21, 2024

azatsatklichov commented Nov 21, 2024

msujew commented Nov 21, 2024 • edited Loading

KUGDev commented Nov 21, 2024

azatsatklichov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asatklichov Sep 5, 2024 •

edited

Loading

asatklichov Sep 5, 2024 •

edited

Loading

msujew commented Nov 21, 2024 •

edited

Loading