Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't auto clean @theia/test package #9

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Don't auto clean @theia/test package #9

merged 1 commit into from
Feb 20, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Feb 20, 2024 •
edited
Loading

@t1m0thyj t1m0thyj marked this pull request as ready for review February 20, 2024 21:24
traeok
traeok approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @t1m0thyj

zFernand0
zFernand0 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped me build locally and pulled the V1.46.1 version
🥳
image

@t1m0thyj t1m0thyj merged commit 3f7697c into main Feb 20, 2024
5 checks passed
@t1m0thyj t1m0thyj deleted the fix/theia-docker-build branch February 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@awharn awharn Awaiting requested review from awharn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '@theia/test/lib/common/collections'
3 participants
@t1m0thyj @zFernand0 @traeok