-
Notifications
You must be signed in to change notification settings - Fork 132
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Zachary Sais
committed
Aug 1, 2017
1 parent
18dc60e
commit 94faa35
Showing
1 changed file
with
1 addition
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94faa35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zsais,
I've watched this commit, and I'm not sure it is a good idea to include the URL path as a prometheus label, I'll explain why:
If you have URLs paths like:
this would be perfect, but if you have URL paths with path params like:
:param1
/action/:param2
Every param combination will result in different URL paths, and therefore, different prometheus labels. This would make harder to group when quering prometheus.
What is your opinion?
Regards,
94faa35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pmoncadaisla,
Thanks for your comments! You're definitely right, once the URL path has params we lose the ability to make consistent queries. I'd initially had
c.HandlerName()
but wasn't a fan of the way it was getting stored. Any ideas on how to get the proper handler or base URL path written? I can revert back toc.HandlerName()
for the time being.