Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Condition UI-string "channel" terminology on >=255, not >255 #5864

Merged

Conversation

chrisbobbe
Copy link
Contributor

Oops; this was missed because I didn't do end-to-end testing before we merged #5830.

Oops; this was missed because I didn't do end-to-end testing before
we merged zulip#5830.
@gnprice
Copy link
Member

gnprice commented Apr 26, 2024

Thanks! Looks good; merging.

I also did some greps for other places where we compare a feature level, and I think we have them all the right way around.

In particular non-strict inequalities are now all "current feature level >= threshold", and strict inequalities are all "<", from reading the output of:

$ git grep 'eatureLevel.*(?<!=)[><]=' 
$ git grep 'eatureLevel.*(?<!=)[><](?!=)' 

and for good measure:

$ git grep '(?<!=)[><]=.*eatureLevel' 
$ git grep '(?<!=)[><](?!=).*eatureLevel' 

@gnprice gnprice merged commit 3b85a50 into zulip:main Apr 26, 2024
1 check passed
@chrisbobbe chrisbobbe deleted the pr-stream-channel-rename-proper-threshold branch April 26, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants