Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify confirmation popups into popup framework #1534

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Unify confirmation popups into popup framework #1534

wants to merge 6 commits into from

Commits on Jul 17, 2024

  1. refactor: views: Require optional parameters to PopUpView to be named. 

    Tests updated.
    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f07058f View commit details
    Browse the repository at this point in the history

  2. refactor: core/views: Extract popup border style into PopUpFrame.

    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ddf2efb View commit details
    Browse the repository at this point in the history

  3. core/views: Support title-less PopUpFrame with reduced height. 

    Ideally the extra height would be calculated automatically in
PopUpFrame.
    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cc3fbf4 View commit details
    Browse the repository at this point in the history

  4. core/views: Remove PopUpConfirmationView location option. 

    These popups are all now implicitly centered.

Tests updated and tidied.
    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b822126 View commit details
    Browse the repository at this point in the history

  5. refactor: core/views: Use show_pop_up for PopUpConfirmationView. 

    Small comment added re importance of retaining self.loop.run() for
signal handler.

Tests updated.
    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    90842d5 View commit details
    Browse the repository at this point in the history

  6. refactor: views: Clarify PopupFrame base classes.

    @neiljp
    neiljp committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    daca945 View commit details
    Browse the repository at this point in the history