Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Syscall with x/sys/unix.IoctlSetWinsize #5

Closed
wants to merge 3 commits into from

Conversation

niten94
Copy link

@niten94 niten94 commented Dec 24, 2024

There are platforms where SYS_IOCTL is not defined probably because libc functions have to be used. Reasons why Syscall cannot be used in any platform may be added or changed but they would be handled in x/sys/unix and Go source code, so the call is replaced in this pull request.

Unrelated small style changes were also done in other commits.

Fixes #3
Fixes #4

@JoeKar
Copy link

JoeKar commented Jan 5, 2025

We've now micro-editor/terminal too. 😉

@niten94
Copy link
Author

niten94 commented Jan 7, 2025

I have submitted the pull request as micro-editor#1.

@niten94 niten94 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build from source on the OpenSolaris/illumos Build failure on illumos/solaris: SYS_IOCTL undefined
2 participants