Changed the internally used System.Linq.Dynamic namespace #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the internally used System.Linq.Dynamic namespace so it is project specific, to avoid interfering with references in other projects.
Means that we can reference both this and System.Linq.Dynamic in the same project. Fixes issue #114
the options were
-reference the nuget for System.Linq.Dynamic (which can't be done thanks to strong naming hell)
-change this library to not be strong named (which will result in gnashing of teeth from those who are currently using strong naming)
-do as this checkin does, and change the namespace so it's project prefixed and won't collide with other libraries.
Went with the last option as it seems path of least resistance. Only breaking issue could be users who have decided to reference this library, and then gone on to use the dynamic linq contained package will have to update their own referenecs. Ideally they should instead be referencing the nuget package, but irrespective, they definitely shouldn't be referencing this package for the purpose of using dynamic linq, and this chagne will not cause unexpected behaviour, it will cause a very obvious compile error.