Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the internally used System.Linq.Dynamic namespace #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstancombe
Copy link

Changed the internally used System.Linq.Dynamic namespace so it is project specific, to avoid interfering with references in other projects.
Means that we can reference both this and System.Linq.Dynamic in the same project. Fixes issue #114

the options were

-reference the nuget for System.Linq.Dynamic (which can't be done thanks to strong naming hell)
-change this library to not be strong named (which will result in gnashing of teeth from those who are currently using strong naming)
-do as this checkin does, and change the namespace so it's project prefixed and won't collide with other libraries.

Went with the last option as it seems path of least resistance. Only breaking issue could be users who have decided to reference this library, and then gone on to use the dynamic linq contained package will have to update their own referenecs. Ideally they should instead be referencing the nuget package, but irrespective, they definitely shouldn't be referencing this package for the purpose of using dynamic linq, and this chagne will not cause unexpected behaviour, it will cause a very obvious compile error.

…oject specific, to avoid interfering with references in other projects.
@BStrat77
Copy link

I'm seeing an ambiguity issue when trying to do a Where clause with the string predicate. Is it possibly related to this? I'm running dev build 146 and it's still happening. Have both Dynamic and Extended (reference in separate NuGets) in the same project. As soon as I uninstall Extended the problem goes away. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants