Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation on running node with docker #289

Closed
wants to merge 2 commits into from
Closed

docs: update documentation on running node with docker #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6906056
fix: use `OutputNote::metadata` and remove `TODO` (#320)
polydez Apr 12, 2024
3d195a8
docs: update documentation on running node with docker
mFragaBA Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ If you intend on running the node inside a Docker container, you will need to fo
2. Run the Docker container

```sh
docker run --name miden-node -p 57291:57291 -d miden-node-image
cargo make docker-run-node
```

This command will run the node as a container named `miden-node` using the `miden-node-image` and make port `57291` available (rpc endpoint).
Expand Down
17 changes: 4 additions & 13 deletions block-producer/src/batch_builder/batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,10 @@ impl TransactionBatch {
}

// TODO: document under what circumstances SMT creating can fail
let created_notes_smt =
BatchNoteTree::with_contiguous_leaves(created_notes.iter().map(|note| {
(
note.id(),
// TODO: Substitute by using just note.metadata() once this getter returns reference
// Tracking PR: https://github.com/0xPolygonMiden/miden-base/pull/593
match note {
OutputNote::Public(note) => note.metadata(),
OutputNote::Private(note) => note.metadata(),
},
)
}))
.map_err(|e| BuildBatchError::NotesSmtError(e, txs))?;
let created_notes_smt = BatchNoteTree::with_contiguous_leaves(
created_notes.iter().map(|note| (note.id(), note.metadata())),
)
.map_err(|e| BuildBatchError::NotesSmtError(e, txs))?;

Ok(Self {
id,
Expand Down
Loading