Fix revert account destroyed with nonexistent target #1282
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the
create2collisionSelfdestructedRevert
tests from the evm-tests test suite were failing with a Kernel panic. This is because inrevert_account_destroyed
, we access thetarget
's balance to undo the balance change carried out inSELF_DESTRUCT
. But in the tests, thetarget
account had to be created when carrying out aSELF_DESTRUCT
, and the revert therefore already deleted it. In that case,mpt_read_state_trie
returns 0 (corresponding to a nonexistent account), and we should not try to change thetarget
's balance.This PR therefore ensures that when a
target
account is nonexistent, we do not try to change its balance.