Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix journal order in sys_selfdestruct #1287

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix journal order in sys_selfdestruct #1287

merged 2 commits into from
Oct 11, 2023

Conversation

wborgeaud
Copy link
Contributor

We have to call %journal_add_account_destroyed after %journal_add_account_created.
See #1282 for discussions.

@wborgeaud wborgeaud requested a review from LindaGuiga October 11, 2023 05:59
@wborgeaud wborgeaud mentioned this pull request Oct 11, 2023
Closed
LindaGuiga
LindaGuiga approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@wborgeaud wborgeaud merged commit 9fd0425 into main Oct 11, 2023
2 checks passed
@wborgeaud wborgeaud deleted the wb/testing_selfdestruct branch October 11, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindaGuiga LindaGuiga LindaGuiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wborgeaud @LindaGuiga