Skip to content

Commit

Permalink
Revert "Apply Consensys audit suggestions"
Browse files Browse the repository at this point in the history
  • Loading branch information
byshape authored Jul 31, 2024
1 parent ef47c45 commit 04cddd4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion test/integration/MerkleStorageInvalidator.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ contract MerkleStorageInvalidatorIntTest is BaseSetup {
BaseSetup.setUp();

for (uint256 i = 0; i < SECRETS_AMOUNT; i++) {
// Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
hashedSecrets[i] = keccak256(abi.encodePacked(i));
hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
}
Expand Down
1 change: 0 additions & 1 deletion test/unit/EscrowFactory.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ contract EscrowFactoryTest is BaseSetup {
function setUp() public virtual override {
BaseSetup.setUp();

// Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
for (uint256 i = 0; i < SECRETS_AMOUNT; i++) {
hashedSecrets[i] = keccak256(abi.encodePacked(i));
hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
Expand Down
2 changes: 0 additions & 2 deletions test/unit/MerkleStorageInvalidator.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ contract MerkleStorageInvalidatorTest is BaseSetup {
bytes32[] memory hashedSecrets = new bytes32[](secretsAmount);
bytes32[] memory hashedPairs = new bytes32[](secretsAmount);

// Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
for (uint256 i = 0; i < secretsAmount; i++) {
hashedSecrets[i] = keccak256(abi.encodePacked(i));
hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
Expand Down Expand Up @@ -63,7 +62,6 @@ contract MerkleStorageInvalidatorTest is BaseSetup {
bytes32[] memory hashedSecrets = new bytes32[](secretsAmount);
bytes32[] memory hashedPairs = new bytes32[](secretsAmount);

// Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
for (uint256 i = 0; i < secretsAmount; i++) {
hashedSecrets[i] = keccak256(abi.encodePacked(i));
hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
Expand Down

0 comments on commit 04cddd4

Please sign in to comment.