Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSM6DSL IMU PR #94

Merged
merged 21 commits into from
Oct 16, 2023
Merged

LSM6DSL IMU PR #94

merged 21 commits into from
Oct 16, 2023

Conversation

cnlohr
Copy link
Collaborator

@cnlohr cnlohr commented Oct 16, 2023

This integrates the LSM6DSL IMU into the swadge ecosystem. There are three outstanding issues:

  1. Need to figure out why modes integrate differently - it should not be time-impactful.
  2. Need to make more examples
  3. Need to improve emulator input

Copy link
Owner

@AEFeinstein AEFeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to test on my swadge, apply auto-formatting, fix up some of the doxygen linkage, and pull it in. Nicely done!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have slightly preferred leaving the path as it was and naming the new component something else, since its more than just an accel. NBD.

* The accelerometer used is a QMA7981.
* The datasheet can be found here: <a href="https://datasheet.lcsc.com/lcsc/2004281102_QST-QMA7981_C457290.pdf">QMA7981
* Datasheet</a>.
* Originally swadges were planned to use a LSM6DSL and a QMC6308, however, because the batteries are so close to the
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot imagine how happy reading this makes me 😁

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preferred approach for binary data is to put it in SPIFFS, optionally with heatshrink compression applied. For the test this is fine, but it may be nice to move 3D object files out of src and into the file system.

@AEFeinstein AEFeinstein merged commit e02f98f into main Oct 16, 2023
1 check passed
@AEFeinstein
Copy link
Owner

@cnlohr I'm leaving this branch up for your further fix. If you already fixed the thing, please delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants