-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks/constraints refactor + Reduced TSID formulation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing. I will take a look once I am done with robot models |
… frame for contacts jacobians)
Added TSID reduced (no torques in QP) scene |
ibergonzani
changed the title
Tasks/constraints refactor
Tasks/constraints refactor + Reduced TSID formulation
Aug 17, 2022
Tests are working fine but scene benchmark fails often in the VelocitySceneQuadraticCost because of jointLimits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #30
Refactor for tasks (previously called Constraints) and actual linear constraints.
Currently added linear constraint:
velocity:
joints limits (velocity, position)
contacts (xero vel)
acceleration(tsid):
joint limits (acceleration, velocity, position, effort)
contacts (zero acc)
rigidbody dynamics
effort limits (for TSID Reduced scene)
In addition to a vector of tasks, a scene has now a vector of vector of constraints
Inside the scene update, they are updated automatically using a RobotModelPtr (update implementation inside constraint class, not scene)
since the joint limits constraints need the control loop time dt. this is passed to the scene through the costructor (default parameter to avoid break existing code).
At the moment all constraints are hardcoded inside of Scenes
In future they might be passed through the configure method?