Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks/constraints refactor + Reduced TSID formulation #40

Merged
merged 30 commits into from
Sep 14, 2022
Merged

Conversation

ibergonzani
Copy link
Contributor

@ibergonzani ibergonzani commented Aug 15, 2022

Same as #30

Refactor for tasks (previously called Constraints) and actual linear constraints.

  • Rename Constraints to Tasks (ConstraintConfig -> TaskConfig, ConstraintStatus -> TaskStatus)
  • Add specific classes for linear constraint
  • Add TSID Scene (AccelerationReducedTSIDScene) that leaves torques out of the QP optimization and computes them afterward

Currently added linear constraint:

velocity:
joints limits (velocity, position)
contacts (xero vel)

acceleration(tsid):
joint limits (acceleration, velocity, position, effort)
contacts (zero acc)
rigidbody dynamics
effort limits (for TSID Reduced scene)

In addition to a vector of tasks, a scene has now a vector of vector of constraints
Inside the scene update, they are updated automatically using a RobotModelPtr (update implementation inside constraint class, not scene)

since the joint limits constraints need the control loop time dt. this is passed to the scene through the costructor (default parameter to avoid break existing code).

At the moment all constraints are hardcoded inside of Scenes
In future they might be passed through the configure method?

@dmronga
Copy link
Contributor

dmronga commented Aug 15, 2022

Thanks for contributing. I will take a look once I am done with robot models

@ibergonzani ibergonzani changed the title Tasks refactor Tasks/constraints refactor Aug 17, 2022
@ibergonzani
Copy link
Contributor Author

Added TSID reduced (no torques in QP) scene

@ibergonzani ibergonzani changed the title Tasks/constraints refactor Tasks/constraints refactor + Reduced TSID formulation Aug 17, 2022
@ibergonzani
Copy link
Contributor Author

Tests are working fine but scene benchmark fails often in the VelocitySceneQuadraticCost because of jointLimits.
At times, Joint position of actuated joints seems to be outside of bounds with the hyrodyn_hybrid model.
(in base branch the joints position is not enforced)

@dmronga dmronga merged commit 2b948f1 into master Sep 14, 2022
@dmronga dmronga deleted the tasks_refactor branch May 9, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants