Fix ssh folder pull #707
Open
Fix ssh folder pull #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramiko seems to have had a slight change in behavior that broke devlib: to save a remote command execution, we attempt to pull any path as file first, and then as a folder if the former failed. This is now broken as paramiko will create an empty destination file when trying to pull as a file. When we attempt again to pull as folder, the destination exists already (empty file) and we raise an exception. To fix that, make sure we cleanup any attempt after pulling as a file before trying again.
When pulling a file from the target, copy all paths as files and follow symlinks if necessary. That fixes issues related to chmod not working on symlinks and generally allows getting any path. If we want to one day preserve symlinks in some capacities, we can always add an option to Target.pull() to do so.
Ensure we use the busybox command in operations involved in file transfers.
* Combine cp and chmod for pull * Make both push and pull use concurrent async code
_prepare_xfer() deals with all the paths resulting from glob expansion, so it can benefit from async capabilities in order to process multiple files concurrently. Convert the internals to async/await to enable useful map_concurrently()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSH pull for folders over SFTP and asyncify the generic part of the push/pull implementation so it can run concurrently for multiple files when globbing is used.