Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssh folder pull #707

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix ssh folder pull #707

wants to merge 5 commits into from

Commits on Nov 20, 2024

  1. ssh: Fix folder pull on SSH connection 

    Paramiko seems to have had a slight change in behavior that broke
devlib: to save a remote command execution, we attempt to pull any path
as file first, and then as a folder if the former failed.

This is now broken as paramiko will create an empty destination file
when trying to pull as a file. When we attempt again to pull as folder,
the destination exists already (empty file) and we raise an exception.

To fix that, make sure we cleanup any attempt after pulling as a file
before trying again.
    @douglas-raillard-arm
    douglas-raillard-arm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b39ecaa View commit details
    Browse the repository at this point in the history

  2. target: Copy symlinks as files when pulling 

    When pulling a file from the target, copy all paths as files and follow
symlinks if necessary. That fixes issues related to chmod not working on
symlinks and generally allows getting any path.

If we want to one day preserve symlinks in some capacities, we can
always add an option to Target.pull() to do so.
    @douglas-raillard-arm
    douglas-raillard-arm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9e160bb View commit details
    Browse the repository at this point in the history

  3. target: Use busybox for file transfer operations 

    Ensure we use the busybox command in operations involved in file
transfers.
    @douglas-raillard-arm
    douglas-raillard-arm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3108910 View commit details
    Browse the repository at this point in the history

  4. target: Reduce the number of commands involved in push/pull 

    * Combine cp and chmod for pull
* Make both push and pull use concurrent async code
    @douglas-raillard-arm
    douglas-raillard-arm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0394bc4 View commit details
    Browse the repository at this point in the history

  5. target: Asyncify Target._prepare_xfer() 

    _prepare_xfer() deals with all the paths resulting from glob expansion,
so it can benefit from async capabilities in order to process multiple
files concurrently.

Convert the internals to async/await to enable useful map_concurrently()
    @douglas-raillard-arm
    douglas-raillard-arm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    03e01b0 View commit details
    Browse the repository at this point in the history