Fix example makefiles to use proper path to symbol files #122
Conversation
Signed-off-by: Gary Oberbrunner <[email protected]>
garyo
force-pushed
the
fix/example-makefiles
branch
from
afc2e52 to
742bd41
Compare
Signed-off-by: Gary Oberbrunner <[email protected]>
garyo
force-pushed
the
fix/example-makefiles
branch
from
feec862 to
eceb067
Compare
|
In my testing, I found that the symbol files are unnecessary on macOS and Linux - probably on Windows too but I'm not set up to test that easily. We set Not specifically related to this commit, but the CMake project has the same error in the macOS arguments. I will open a new PR to set visibility=hidden in a cross-platform way there. |
Per @john-paulsmith's comments, symbol files are not needed when using `-fvisibility=hidden` and the `EXPORT` macro. I deleted the symbol files too. We're using `--std=gnu++14` elsewhere, and some of the examples use initializer syntax so this fixes the build. Also added building Examples in the CI build so we'll know if they break. Didn't do Windows yet, and the Support examples' Makefile also needs some work, which is a separate issue. Fixes #122. Signed-off-by: Gary Oberbrunner <[email protected]>
Note: the Support (C++) examples still have many internal C++ symbols exported, at least on MacOS. But they did before as well, so this commit only improves the situation. Signed-off-by: Gary Oberbrunner <[email protected]>
Signed-off-by: Gary Oberbrunner <[email protected]>
|
I have this working, but I see you've also got something similar in #141, @john-paulsmith . I'll merge your changes there into this or vice versa because this also has some only tangentially-related build fixes. |
Signed-off-by: Gary Oberbrunner <[email protected]>
Signed-off-by: Gary Oberbrunner <[email protected]>
Signed-off-by: Gary Oberbrunner <[email protected]>
The CMake builds are working now, but the examples were still using an old path to the symbol files.