Remove symbol files as these are no longer needed #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have only tested this complete changeset on macOS, although I verified the concept on Linux too. Comments from a Windows perspective would be appreciated, I believe Windows symbol visibility is hidden by default and the use of Is there any reason to keep the symbol files around for plug-in/host build scripts? |
|
If this PR is merged, I believe #122 can be discarded. |
Both the CMake and Makefile projects included compiler arguments to set symbol visibility to hidden and expose only the OfxGetNumberOfPlugins and OfxGetPlugin symbols. The CMake project has been changed to use built-in functionality to control symbol visibility, reducing the amount of platform-specific code that needs to be maintained.
Furthermore, all our examples use __attribute__((visibility("default"))) to expose necessary symbols, rendering the symbol files unnecessary, so all references to the symbol files, and the files themselves have been removed.
Signed-off-by: John-Paul Smith <[email protected]>
john-paulsmith
force-pushed
the
symbol-visibility
branch
from
ef23f46 to
b3f99ed
Compare
garyo
added a commit
that referenced
this pull request
Feb 24, 2024
Signed-off-by: Gary Oberbrunner <[email protected]>
|
Closing; all in #122 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the CMake and Makefile projects included compiler arguments to set symbol visibility to hidden and expose only the
OfxGetNumberOfPluginsandOfxGetPluginsymbols. The CMake project has been changed to use built-in functionality to control symbol visibility, reducing the amount of platform-specific code that needs to be maintained.Furthermore, all our examples use
__attribute__((visibility("default")))to expose necessary symbols, rendering the symbol files unnecessary, so all references to the symbol files, and the files themselves have been removed.