Paper - Heidi Zhang

[qingyuanhz1]

No description provided.

[kaidamasaki]

Well done!

I left a couple of little style comments but overall things looked great! 😃

[kaidamasaki]

This is a really smart way to find the indexes!

[kaidamasaki]

This would be clearer if you used the constants:

Suggested change

	if (currentPlayer === 'x') {
	if (currentPlayer === PLAYER_1) {

[kaidamasaki]

You can use a few built in methods to clean this up.

You can use flat() instead of your first loop:

Suggested change

	let onedSquares = [];
	for (const row of squares) {
	for (const square of row) {
	onedSquares.push(square)
	}
	}
	return onedSquares.map((square) => {
	return (
	<Square
	value={ square.value }
	id={ square.id }
	onClickCallback={ onClickCallback }
	/>
	)
	})
	let onedSquares = squares.flat();
	return onedSquares.map((square) => {
	return (
	<Square
	value={ square.value }
	id={ square.id }
	onClickCallback={ onClickCallback }
	/>
	)
	})

And then JS actually includes the built in method flatMap that does a flat followed by a map all in one step:

Suggested change

	let onedSquares = [];
	for (const row of squares) {
	for (const square of row) {
	onedSquares.push(square)
	}
	}
	return onedSquares.map((square) => {
	return (
	<Square
	value={ square.value }
	id={ square.id }
	onClickCallback={ onClickCallback }
	/>
	)
	})
	return squares.flatMap((square) => {
	return (
	<Square
	value={ square.value }
	id={ square.id }
	onClickCallback={ onClickCallback }
	/>
	)
	})