Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspiration Board React App - Emilce - Octos #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

emilcecarlisa
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. The form receives information from the user, changes the local state of the form as the user types input, then upon form submission we make a callback to the Board where the new card is added to the current list.
How did you learn how to use the API? Examples from class and additional readings.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? Used componentDidMount() because it runs after the initial render and retrieves the list which the user wants to see immediately upon landing on the page.
Explain the purpose of a Snapshot test. A snapshot test is used to tests components as they interact with each other or in the case of a shallow test, allows you to test only certain parts of a component's lifecycle.
What purpose does Enzyme serve in testing a React app? Enzyme is a library that allows you to manipulate DOM for the purpose of running tests and makes things human readable through serialization.
Summary

// const textValue = 'Encouraging message';
const onClick = jest.fn();
const wrapper = shallow(
<button type="submit" onClick={onClick}></button>
Copy link

@Hamled Hamled Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this JSX code does not use the Card component, this doesn't actually constitute a test for that component.

Instead we should use something like:

const wrapper = shallow(
  <Card id={0} text="Hello" emojis="" onDeleteCard={onClick} />
);

@Hamled
Copy link

Hamled commented Jun 22, 2018

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene
Comprehension questions
General
Card Component renders the data provided as props
Board Component takes a URL and renders the list of Cards and passes in callback functions Mostly. The Board component does receive a URL through props, but actually uses three constants defined within the same file instead. A more modular approach would be to have the component use the base URL prop and combine it with the boardName prop to create the complete URL needed for Axios requests.
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component
API
GET request made in componentDidMount
DELETE request made in callback function
POST request made in callback function passed to NewCardForm component.
Snapshot testing Mostly. There are a few cases where we're not truly testing a snapshot of the component being tested (see comments), or where we could probably have additional snapshot tests.
Styling
Overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants