forked from AdaGold/inspiration-board
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspiration Board React App - Emilce - Octos #23
Open
emilcecarlisa
wants to merge
10
commits into
Ada-C9:master
Choose a base branch
from
emilcecarlisa:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1f523d1
Setting upstream and json file correction
emilcecarlisa 7dac465
Manually added cards in board
emilcecarlisa 59a52aa
emojis and individual cards showing
emilcecarlisa 7a14b8e
Don't know last time I pushed
emilcecarlisa 3366c97
Form message input up but not adding to collection
emilcecarlisa 2352bb7
Adding card to board
emilcecarlisa dc00b8a
Adding and deleting correctly
emilcecarlisa 72cdcb2
Completed dropdown for emoji form
emilcecarlisa 40702b6
Added status messages
emilcecarlisa 2f315fb
Added tests to Card, Board, and App components
emilcecarlisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
.board { | ||
display: flex; | ||
flex-wrap: wrap; | ||
justify-content: center; | ||
} | ||
|
||
.validation-errors-display { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import React from 'react'; | ||
import Board from './Board'; | ||
import { mount, shallow } from 'enzyme'; | ||
|
||
import NewCardForm from './NewCardForm'; | ||
|
||
describe('Board', () => { | ||
test('shallow mount', () => { | ||
const board = shallow( | ||
<Board updateStatusCallback={()=>{}} /> | ||
); | ||
|
||
expect(board).toMatchSnapshot(); | ||
|
||
board.unmount(); | ||
}); | ||
|
||
test('render a new card form', () =>{ | ||
const form = shallow( | ||
<NewCardForm /> | ||
); | ||
expect(form).toMatchSnapshot(); | ||
}); | ||
|
||
test('render a new card form', () =>{ | ||
const form = shallow( | ||
<NewCardForm addCardCallback={()=>{}} /> | ||
); | ||
|
||
expect(form).toMatchSnapshot(); | ||
|
||
form.unmount(); | ||
}); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react'; | ||
import Card from './Card'; | ||
import { mount, shallow } from 'enzyme'; | ||
|
||
describe('Card', () => { | ||
test('onClick handler working', () => { | ||
// const textValue = 'Encouraging message'; | ||
const onClick = jest.fn(); | ||
const wrapper = shallow( | ||
<button type="submit" onClick={onClick}></button> | ||
); | ||
|
||
expect(wrapper).toMatchSnapshot(); | ||
|
||
wrapper.find('button').simulate('click'); | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this JSX code does not use the
Card
component, this doesn't actually constitute a test for that component.Instead we should use something like: