fix: [windows] Fix TextureRender crash #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump minimum supported Flutter SDK >= 3.0.0 to allow us to reduce the maintenance cost.
|
Need this PR #2001 |
We need this change(flutter/engine@90815e5), which was released in Flutter SDK 3.7.0 to fix a crash on Windows(#1999) This PR is preparing for the fix.
littleGnAl
added a commit
that referenced
this pull request
Sep 6, 2024
We need this change(flutter/engine@90815e5), which was released in Flutter SDK 3.7.0 to fix a crash on Windows(#1999) This PR is preparing for the fix.
littleGnAl
added a commit
that referenced
this pull request
Sep 6, 2024
We need this change(flutter/engine@90815e5), which was released in Flutter SDK 3.7.0 to fix a crash on Windows(#1999) This PR is preparing for the fix.
littleGnAl
added a commit
that referenced
this pull request
Sep 6, 2024
We can't delete the `TextureRender` in the `VideoViewController::DestroyTextureRender`, because the `flutter::TextureRegistrar::UnregisterTexture` is called in the Flutter rasterizer thread, it's not thread-safe. We change the `VideoViewController::renderers_` to `std::map<int64_t, TextureRender *>`, which holds the raw pointer `TextureRender *`, and delete the `TextureRender ` in the `flutter::TextureRegistrar::UnregisterTexture` callback which introduces from Flutter SDK 3.7.0.
littleGnAl
added a commit
that referenced
this pull request
Sep 13, 2024
We need this change(flutter/engine@90815e5), which was released in Flutter SDK 3.7.0 to fix a crash on Windows(#1999) This PR is preparing for the fix.
littleGnAl
added a commit
that referenced
this pull request
Sep 13, 2024
We can't delete the `TextureRender` in the `VideoViewController::DestroyTextureRender`, because the `flutter::TextureRegistrar::UnregisterTexture` is called in the Flutter rasterizer thread, it's not thread-safe. We change the `VideoViewController::renderers_` to `std::map<int64_t, TextureRender *>`, which holds the raw pointer `TextureRender *`, and delete the `TextureRender ` in the `flutter::TextureRegistrar::UnregisterTexture` callback which introduces from Flutter SDK 3.7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't delete the
TextureRenderin theVideoViewController::DestroyTextureRender, because theflutter::TextureRegistrar::UnregisterTextureis called in the Flutter rasterizer thread, it's not thread-safe.We change the
VideoViewController::renderers_tostd::map<int64_t, TextureRender *>, which holds the raw pointerTextureRender *, and delete theTextureRenderin theflutter::TextureRegistrar::UnregisterTexturecallback which introduces from Flutter SDK 3.7.0.