feat(themes): add component level tokens for themeing #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
from
78e7180 to
6598e33
Compare
2 tasks
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
4 times, most recently
from
e5bf598 to
b4741e3
Compare
jordanjones243
requested changes
May 29, 2024
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
2 times, most recently
from
0584284 to
3c74cf1
Compare
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
2 times, most recently
from
acc10e6 to
10d2ba0
Compare
6 tasks
jordanjones243
requested changes
Jun 17, 2024
Advisory variant has been removed. Warning variant is the intended replacement.
https://github.com/orgs/AlaskaAirlines/discussions/556 This code diff represents changes made to multiple files in a Git repository. Let's go through the changes step by step: 1. **.github/settings.yml**: - Line 35: The `master` branch is modified. Instead of just specifying the branch name, a YAML anchor (`&default_protection`) is introduced to define a set of branch protection settings that can be reused. - Line 46: The `require_code_owner_reviews` setting for the `master` branch is changed from `false` to `true`. This means that code owners must review and approve pull requests before they can be merged into the `master` branch. - Line 56: The `contexts` setting for the `master` branch is modified. Two additional status checks, `"test (20.x)"` and `"license/cla"`, are added to the existing checks `"test (18.x)"`. These status checks must pass before a pull request can be merged into the `master` branch. - Lines 61-64: Two more branches, `beta` and `master`, are added with the same branch protection settings as the `master` branch. 2. **.github/workflows/testPublish.yml**: - Line 28: The condition for the `release` job is modified. Previously, it would only trigger on a push to the `master` branch. Now, it will also trigger on a push to the `beta` branch. 3. **package.json**: - Line 96: The `branches` array in the `release` configuration is modified. The `master` branch is still included, but now the `beta` branch is also included with an additional property `prerelease` set to `true`. This indicates that releases from the `beta` branch should be treated as pre-releases. These changes introduce branch protection settings, status checks, and release configurations for the `master` and `beta` branches in the repository. The modifications ensure that code owners review and approve pull requests, and that specific status checks pass before merging into these branches. Additionally, the `release` job is triggered not only on the `master` branch but also on the `beta` branch, treating releases from the `beta` branch as pre-releases. Changes to be committed: modified: .github/settings.yml modified: .github/workflows/testPublish.yml modified: package.json
This code diff shows changes made to the `.github/workflows/testPublish.yml` and `package.json` files. Let's break it down: In the `.github/workflows/testPublish.yml` file: - Line 28: A new step has been added under the `jobs.build` section. It runs the command `npm run build:test`. This step is responsible for building the project specifically for testing purposes. - Line 42: The existing `npm run build` command under the `jobs.release` section has been replaced with `npm run build:release`. This change modifies the build process for the release job, indicating that it should build the project specifically for release purposes. In the `package.json` file: - Line 144: The `scripts` section has been modified. The `build` script has been updated to include only the necessary build steps for Sass, rendering, and generating types. The `build:test` script has been added to run tests and linters. The `build:release` script has been added to include additional build steps for API documentation, bundling, and post-installation tasks. See Discussion: https://github.com/orgs/AlaskaAirlines/discussions/523 Changes to be committed: modified: .github/workflows/testPublish.yml modified: package.json
blackfalcon
force-pushed
the
jbaker/customTokenPoc
branch
from
10d2ba0 to
ec7d241
Compare
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
2 times, most recently
from
5a1bf93 to
5a0547a
Compare
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
from
5a0547a to
8a05394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #112
Summary:
All token work is updated to support the new component theme infrastructure.
advisorywas removed as part of the design switch towarningonly.The additional variants were added.
varient examples were updated to better show each varient in a recognizable way
Type of change:
Please delete options that are not relevant.
Checklist:
Verification
DEFAULT
defaultvariant renders correctlyaccentvariant renders correctlydisabledvariant renders correctlyemphasisvariant renders correctlyerrorvariant renders correctlyinfovariant renders correctlysecondaryvariant renders correctlysubtlevariant renders correctlysuccessvariant renders correctlytertiaryvariant renders correctlywarningvariant renders correctlyINVERSE
defaultvariant renders correctlyaccentvariant renders correctlydisabledvariant renders correctlyemphasisvariant renders correctlyerrorvariant renders correctlyinfovariant renders correctlysecondaryvariant renders correctlysubtlevariant renders correctlysuccessvariant renders correctlytertiaryvariant renders correctlywarningvariant renders correctlyBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team