Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #112

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #116, #118, #120, #126 or #130
Closed
2 tasks

Update color tokens for theming support #112

jordanjones243 opened this issue Mar 13, 2024 · 1 comment · Fixed by #116, #118, #120, #126 or #130
Assignees
Labels

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature Type: Question auro-icon not-reviewed Issue has not been reviewed by Auro team members labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Tier 1
    • Logo color: var(--ds-color-brand-midnight-400, $ds-color-brand-midnight-400);
    • On dark logo color: var(--ds-color-base-white, $ds-color-base-white);

@jordanjones243 jordanjones243 linked a pull request Mar 15, 2024 that will close this issue
6 tasks
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label May 7, 2024
@jason-capsule42 jason-capsule42 linked a pull request May 29, 2024 that will close this issue
33 tasks
@jason-capsule42 jason-capsule42 removed a link to a pull request Jun 14, 2024
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jun 18, 2024 that will close this issue
33 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jun 18, 2024 that will close this issue
33 tasks
@blackfalcon blackfalcon linked a pull request Jul 18, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 16, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Aug 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment