Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add component level tokens for theming #118

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Jun 18, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #112

Summary:

All token work is updated to support the new component theme infrastructure.

advisory was removed as part of the design switch to warning only.

The additional variants were added.

varient examples were updated to better show each varient in a recognizable way

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • No linter issues
  • All automated tests pass
  • New Tier 3 component token exists
  • Advisory variant is removed
  • API Page "Theme" section is valid

DEFAULT

  • default variant renders correctly
  • accent variant renders correctly
  • disabled variant renders correctly
  • emphasis variant renders correctly
  • error variant renders correctly
  • info variant renders correctly
  • secondary variant renders correctly
  • subtle variant renders correctly
  • success variant renders correctly
  • tertiary variant renders correctly
  • warning variant renders correctly

INVERSE

  • default variant renders correctly
  • accent variant renders correctly
  • disabled variant renders correctly
  • emphasis variant renders correctly
  • error variant renders correctly
  • info variant renders correctly
  • secondary variant renders correctly
  • subtle variant renders correctly
  • success variant renders correctly
  • tertiary variant renders correctly
  • warning variant renders correctly

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Advisory variant has been removed. Warning variant is the intended replacement.
@jason-capsule42 jason-capsule42 self-assigned this Jun 18, 2024
@jason-capsule42 jason-capsule42 linked an issue Jun 18, 2024 that may be closed by this pull request
2 tasks
@jason-capsule42 jason-capsule42 marked this pull request as ready for review June 18, 2024 17:07
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner June 18, 2024 17:07
@jason-capsule42 jason-capsule42 force-pushed the jbaker/customTokenPoc branch 2 times, most recently from d5a2dc6 to b16ada1 Compare June 18, 2024 17:52
BREAKING CHANGE: advisory varient removed
@jason-capsule42 jason-capsule42 force-pushed the jbaker/customTokenPoc branch from b16ada1 to 478ece3 Compare June 18, 2024 17:53
@jason-capsule42 jason-capsule42 merged commit b854e61 into beta Jun 18, 2024
1 check passed
@jason-capsule42 jason-capsule42 deleted the jbaker/customTokenPoc branch June 18, 2024 18:10
@blackfalcon blackfalcon restored the jbaker/customTokenPoc branch June 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
2 participants