add component level tokens for theming #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackfalcon
force-pushed
the
jbaker/customTokenPoc
branch
2 times, most recently
from
a958d7f to
607dbca
Compare
2 tasks
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
from
607dbca to
5c8046b
Compare
BREAKING CHANGE: Advisory variant has been removed. Warning variant is the intended replacement.
jason-capsule42
force-pushed
the
jbaker/customTokenPoc
branch
from
5c8046b to
f5c8e19
Compare
jason-capsule42
approved these changes
Jun 18, 2024
|
🎉 This PR is included in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #112
Summary:
All token work is updated to support the new component theme infrastructure.
advisorywas removed as part of the design switch towarningonly.The additional variants were added.
varient examples were updated to better show each varient in a recognizable way
Type of change:
Please delete options that are not relevant.
Checklist:
Verification
DEFAULT
defaultvariant renders correctlyaccentvariant renders correctlydisabledvariant renders correctlyemphasisvariant renders correctlyerrorvariant renders correctlyinfovariant renders correctlysecondaryvariant renders correctlysubtlevariant renders correctlysuccessvariant renders correctlytertiaryvariant renders correctlywarningvariant renders correctlyINVERSE
defaultvariant renders correctlyaccentvariant renders correctlydisabledvariant renders correctlyemphasisvariant renders correctlyerrorvariant renders correctlyinfovariant renders correctlysecondaryvariant renders correctlysubtlevariant renders correctlysuccessvariant renders correctlytertiaryvariant renders correctlywarningvariant renders correctlyBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team