Upgrade to supoprt new Auro design tokens #94 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackfalcon
force-pushed
the
dsande/newTokens/94
branch
from
8d1aae1 to
36eef02
Compare
blackfalcon
added a commit
to AlaskaAirlines/Icons
that referenced
this pull request
Oct 11, 2023
This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use. See AlaskaAirlines/auro-icon#95 This update has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected. Changes to be committed: modified: src/data/icons.json
6 tasks
jason-capsule42
requested changes
Oct 11, 2023
blackfalcon
added a commit
to AlaskaAirlines/Icons
that referenced
this pull request
Oct 12, 2023
This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use. See AlaskaAirlines/auro-icon#95 This update has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected. Changes to be committed: modified: src/data/icons.json
blackfalcon
added a commit
to AlaskaAirlines/Icons
that referenced
this pull request
Oct 12, 2023
This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use. See AlaskaAirlines/auro-icon#95 This update includes a solution that applies a variable with a variable fallback with a hard value fallback. The --auro token was specifically listed first as this is an order of expectation from in-the-wild auro elements using the legacy --auro token. It has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected. Changes to be committed: modified: src/_icons.scss modified: src/data/icons.json
blackfalcon
force-pushed
the
dsande/newTokens/94
branch
from
36eef02 to
caa1a8d
Compare
This commit updates all the token references to support the new design token naming spec. All CSS also supports fallback values to ensure smooth transition from legacy to new. TODO: There are 2 to-dos in this commit. Once there is an assumption that most teams have transitioned to the new token spec, the code that these to-dos are referencing can be removed as well as any npm package or reference to the legacy tokens. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: src/alaskaStyle.scss modified: src/iconStyle.scss modified: src/style.scss
This commit also removed the unnecessary dist:js action that is no longer needed due to the updated .npmignore build pipeline spec. Changes to be committed: modified: package-lock.json modified: package.json
blackfalcon
force-pushed
the
dsande/newTokens/94
branch
from
caa1a8d to
6c9278c
Compare
jason-capsule42
previously approved these changes
Oct 12, 2023
blackfalcon
added a commit
to AlaskaAirlines/Icons
that referenced
this pull request
Oct 12, 2023
This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use. See AlaskaAirlines/auro-icon#95 This update includes a solution that applies a variable with a variable fallback with a hard value fallback. The --auro token was specifically listed first as this is an order of expectation from in-the-wild auro elements using the legacy --auro token. It has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected. Changes to be committed: modified: src/_icons.scss modified: src/data/icons.json
blackfalcon
added a commit
to AlaskaAirlines/Icons
that referenced
this pull request
Oct 12, 2023
This commit reverts the revert for using the new Auro design token name spec. The revert happened due to a side-effect with auro-icon and the customSize feature. The auro-icon element was updated to allow for more flexibility in token use. See AlaskaAirlines/auro-icon#95 This update includes a solution that applies a variable with a variable fallback with a hard value fallback. The --auro token was specifically listed first as this is an order of expectation from in-the-wild auro elements using the legacy --auro token. It has been verified that regardless of version of tokens a consumer has installed, or none at all, the customSize feature will work as expected. Changes to be committed: modified: src/_icons.scss modified: src/data/icons.json
The code changes here represent the last step of removing any repo dependency on the legacy --auro design tokens. Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: src/style.scss
blackfalcon
force-pushed
the
dsande/newTokens/94
branch
from
ce50915 to
12672cb
Compare
jordanjones243
previously approved these changes
Oct 30, 2023
This commit updates the default URI from unpkg to jsdelivr as unpkg continues to be unstable in most cases. Changes to be committed: modified: src/auro-icon.js
Changes to be committed: modified: docs/api.md
Changes to be committed: modified: package-lock.json modified: package.json
jordanjones243
requested changes
Oct 30, 2023
Changes to be committed: modified: package.json
jordanjones243
approved these changes
Oct 30, 2023
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #94
Summary:
This commit updates all the token references to support the new design token naming spec. All CSS also supports fallback values to ensure a smooth transition from legacy to new.
TODO: There are 2 to-dos in this commit. Once there is an assumption that most teams have transitioned to the new token spec, the code that these to-dos are referencing can be removed as well as any npm package or reference to the legacy tokens.
Changes to be committed:
modified: package-lock.json
modified: package.json
modified: src/alaskaStyle.scss
modified: src/iconStyle.scss
modified: src/style.scss
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team