-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rover: add NAV_GUIDED_ENABLED support #10775
Conversation
@OXINARF, could you have a peek at this when you have time? It's not desperately urgent of course so whenever is fine.. I've tested it and I think it's OK but I'd like a 2nd opinion before merging 'cuz I pretty much always make a mistake :-) |
confirmed working on our hardware |
commands are placed in numerical order
this is called from nav_guided_start()
this allows sending the location to an offboard navigation system also add text string for nav-guided-enable command
this supports sending the position target to an offboard navigation controller
also adds support for sending position targets to offboard controller which is assumed to return velocity commands
7ef34e9
to
53ee7dd
Compare
also guided's limit_breached made const also guided limit check uses is_positive
53ee7dd
to
d7b644e
Compare
I think I've addressed pretty much all the items raised during the review so I'll merge after it passes travis. thanks @peterbarker! |
doh! @jmachuca77 found something wrong... |
@magicrub, that's OK, now it's a support issue is all.. |
@magicrub yeah its not a real issue, that's why I did not comment. Works once you know how it should work haha. |
This PR adds support to Rover for the NAV_GUIDED_ENABLE and DO_GUIDED_LIMITS commands.
Supporting these commands allows "Guided within Auto" which means an external navigation source (like ROS) can temporarily take control of the vehicle during a mission.
This feature is very similar to what is already in Copter but there are some changes:
Similar to copter, the DO_GUIDED_LIMITS command allows the user to specify a timeout and a safe radius (i.e. a small fence) to help ensure the external controller doesn't do anything crazy
This has been tested in SITL and on a real vehicle. Here's a video of the test using ROS as the external path planner.
There are some related changes to other system that I will take care of separately from this PR:
Ah, there are also two small changes to Copter that should be non-functional changes to remove a duplicate call and fix some formatting and comments.