chain fix + qol #352
clippy
5 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 5 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.2 (25ef9e3d8 2024-04-09)
- cargo 1.77.2 (e52e36006 2024-03-26)
- clippy 0.1.77 (25ef9e3 2024-04-09)
Annotations
Check failure on line 229 in unreal_asset/unreal_asset_base/src/unversioned/mod.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
error: this `let...else` may be rewritten with the `?` operator
--> unreal_asset/unreal_asset_base/src/unversioned/mod.rs:227:9
|
227 | / let Some(parent) = ancestry.get_parent() else {
228 | | return None;
229 | | };
| |__________^ help: replace it with: `let parent = ancestry.get_parent()?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Check failure on line 249 in unreal_asset/unreal_asset_base/src/types/fname.rs
github-actions / clippy
function cannot return without recursing
error: function cannot return without recursing
--> unreal_asset/unreal_asset_base/src/types/fname.rs:247:5
|
247 | / fn eq(&self, other: &String) -> bool {
248 | | self == other
249 | | }
| |_____^
|
note: recursive call site
--> unreal_asset/unreal_asset_base/src/types/fname.rs:248:9
|
248 | self == other
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion
= note: `-D clippy::unconditional-recursion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unconditional_recursion)]`
Check failure on line 716 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
error: this `let...else` may be rewritten with the `?` operator
--> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:714:9
|
714 | / let Some(store_place) = self.key_map.get(key) else {
715 | | return None;
716 | | };
| |__________^ help: replace it with: `let store_place = self.key_map.get(key)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
Check failure on line 700 in unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
error: this `let...else` may be rewritten with the `?` operator
--> unreal_asset/unreal_asset_base/src/containers/indexed_map/mod.rs:698:9
|
698 | / let Some(store_place) = self.index_map.get(&index) else {
699 | | return None;
700 | | };
| |__________^ help: replace it with: `let store_place = self.index_map.get(&index)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `-D clippy::question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
Check failure on line 62 in unreal_asset/unreal_asset_base/src/containers/chain.rs
github-actions / clippy
read amount is not handled
error: read amount is not handled
--> unreal_asset/unreal_asset_base/src/containers/chain.rs:62:33
|
62 | ... first.as_slice().read(buf)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: use `Read::read_exact` instead, or handle partial reads
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
= note: `#[deny(clippy::unused_io_amount)]` on by default