-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress block: stop video overflowing containers on smaller screens #37025
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
. "' style='max-width:" . esc_attr( $videopress_options['width'] ) | ||
. "px;' src='" . esc_attr( $iframe_url ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will also need to set aspect ratio, e.g. I was testing aspect-ratio: 16 / 9;
but I'm guessing we can calculate it or use the real width/height:
aspect-ratio: $videopress_options['width'] / $videopress_options['height'];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsl were you able to test this last week? Which method did you use? We've tried following the test instructions in the comment for Simple and Atomic, but the code that gets patched isn't being executed.
FYI, Feelin' Good is now broken in prod, which is a separate issue I need to look at. The Freddie theme also has the same issue with the Video Press player and can be used instead.
f3fd42a
to
cec9469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed: Please disregard this comment.
What we know of the current code:
And on a sidenote, for Simple Sites, the Feelin' Good theme is broken. More context in this thread: p1722849483789529/1722846054.430179-slack-C04H4NY6STW |
cec9469
to
3655327
Compare
@Automattic/apex FYI, Mike is working on this VideoPress related issue. |
131f8f2
to
5540514
Compare
Follow on from https://github.com/Automattic/jetpack/pull/37025/files?w=1#r1703896494 Rebased and reverted the package changelog/version changes, were those needed? I'm not across how the videopress player is shipped but it looks like it's part of Jetpack proper. Added a commit to add the aspect ratio calc but I'm waiting on sandbox sync to test - it's slow today for some reason. |
Tagging @Automattic/jetpack-agora since it's block-related. |
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
Fixes Automattic/themes#7682
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: