-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not force VS Code settings #37498
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
Pending discussion here: p1HpG7-sQE-p2 |
cff58fa
to
720a957
Compare
Looks like #37505 pushed more changes to |
Co-authored-by: Brad Jorsch <[email protected]>
9be4951
to
c02fbb2
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
We currently prevent users from configuring their VS Code workspace when working in the Jetpack monorepo. This provides a bad user experience.
This PR proposes moving the "sanctioned" settings to
settings.dist.json
, available for the user to copy as desired.It also introduces a
tools/install-vscode-settings.sh
script that will copy the settings template file in place if one doesn't yet exist.Finally, it introduces a
.vscode/task.json
file that will run said script when opening the folder in VS Code (so long as scripts are enabled in VS Code). One can manually trigger this in VS Code with the "Run Tasks" command.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: