Fix VS Code settings and its lints

[manzoorwanijk]

There are lints in .vscode/settings.json and I don't know how but those lints are fixed everytime I run pnpm install or switch branches and I have to discard it everytime and it's annoying.

Proposed changes:

• Fix lints in VS Code settings

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Just check that ESLint etc. fixes the lints in VS Code

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[anomiex]

I note this bit was probably accidentally added in #37418 (they also tried adding .vscode/settings.json to .gitignore, redundantly). Probably it should have been in the user's config instead, leaving this file to only specify exclusions and locations of linter programs.

But I'm going to punt on all this to @tbradsha who has strong opinions on this file. 😀

[tbradsha]

strong opinions on this file

Indeed, mostly centering around this PR's statement that "it's annoying"; I'll put up a post today soliciting more feedback. In the meantime, it's probably best to just remove the editor.codeActionsOnSave section.

[manzoorwanijk]

Closing in favour of #37498