Introducing wpcom site helper plugin into the Monorepo. #37737

zinigor · 2024-06-06T13:17:42Z

Proposed changes:

Adds a new project plugin for wpcomsh.
Introduces linter and static analysis for the project.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Go to '..'

…comsh#1722

…sh#1720

…pcomsh#1724 * Bump version to 3.14.54 * Update wc-calypso-bridge to 2.3.9

…wpcomsh#1726 * Bump version to 3.14.55 * Update wc-calypso-bridge to 2.3.10

…comsh#1728

…tomattic/wpcomsh#1714

…he classic admin interface Automattic/wpcomsh#1725 * Remove Jetpack > Manage menu item as part of the wpcom navigation redesign * Use the flag wpcom_is_nav_redesign_enabled * Remove function_exists * Add checks for Jetpack and Jetpack_Options

* Use jetpack-mu-wpcom v5.15.0 * wpcomsh bump to 13.15.1 * Use jetpack-mu-wpcom v5.15.1

…sh#1732

* initial commit * earliear hook * working prototype * fixes * fix constant * linting + comments * linting * more linting * mooore linting * version bump --------- Co-authored-by: Andrés Blanco <[email protected]>

* Use jetpack-mu-wpcom v5.15.2 * wpcomsh bump to 13.15.4

* Updating jetpack-mu-wpcom to 5.6.0. * Bump version to 3.16.0.

* Use jetpack-mu-wpcom v5.16.1 * wpcomsh bump to 3.16.1

* Add a code deployment logs entry endpoint * Fix linting errors * Rename class file * Fix linting issues * Fix linting errors * Fix include for logs endpoint * Change the endpoint url and assemble the log path in the endpoint based on run and deployment id

…c/wpcomsh#1739

…tomattic/wpcomsh#1669 * Correctly read/update synced color scheme when saving from wp-admin --------- Co-authored-by: Ashar Fuadi <[email protected]>

* Use jetpack-mu-wpcom v5.17.0 * wpcomsh bump to 3.17.1

…#1742

…pcomsh#1744 * Bump wc-calypso-bridge to 2.3.11 * Bump version to 3.17.3

* GitHub Deployments: Remove feature flag call * Bump WPCOMSH version to 3.17.4

* Use jetpack-mu-wpcom v5.18.0 * wpcomsh bump to 3.17.5

…comsh#1749 * Jetpack: move away from deprecated class Fixes #292 Fixes #399 This class was deprecated years ago. We can now safely move to its replacement. * Bump version

…h#1748 * Scheduled Updates: Add menu item for eligible sites * Version bump

* Use jetpack-mu-wpcom v5.19.0 * Bump wpcomsh

…wpcomsh#1753 * Filter migrations started by migrateguru * Bump files * Revert "Bump files" This reverts commit 34cd1f6b665cdb2f47124e29274bea3646e8e022. * Bump

* Jetpack: replace dep build_raw_urls calls Replace deprecated Jetpack::build_raw_urls() calls with Status->get_site_suffix calls. * Fix lint spacing * Resorting to check class existence instead of method existence. --------- Co-authored-by: Igor Zinovyev <[email protected]>

anomiex

Spotted a few more things we might want to clean up.

projects/plugins/wpcomsh/bin/create-github-release.sh

projects/plugins/wpcomsh/composer.json

projects/plugins/wpcomsh/feature-plugins/hooks.php

projects/plugins/wpcomsh/frontend-notices/gifting-banner/gifting-banner.php

projects/plugins/wpcomsh/i18n.php

projects/plugins/wpcomsh/plugin-hotfixes.php

projects/plugins/wpcomsh/wpcomsh.php

anomiex · 2024-06-12T12:45:52Z

Also remember we don't want to squash-and-merge this PR, we want to go in the settings and enable "Allow merge commits" to preserve the imported history. Then disable that again as soon as we've merged this.

Co-authored-by: Brad Jorsch <[email protected]>

…ng-banner.php Co-authored-by: Brad Jorsch <[email protected]>

Co-authored-by: Brad Jorsch <[email protected]>

This reverts commit 1a8f0f1.

This reverts commit 0e38e6e.

hideandgeek404 and others added 30 commits February 28, 2024 09:53

Adding "reset/data_reset.php" as an incompatible plugin Automattic/wp…

3b64b01

…comsh#1722

Blaze: Activate the moule when the site is launching Automattic/wpcom…

4c5da0b

…sh#1720

Bump version to 3.14.53 Automattic/wpcomsh#1723

953945c

Update wc-calypso-bridge to 2.3.9 and wpcomsh to 3.14.54 Automattic/w…

9b8ca88

…pcomsh#1724 * Bump version to 3.14.54 * Update wc-calypso-bridge to 2.3.9

Update wc-calypso-bridge to 2.3.10 and wpcomsh to 3.14.55 Automattic/…

6046151

…wpcomsh#1726 * Bump version to 3.14.55 * Update wc-calypso-bridge to 2.3.10

Switch from legacy image circleci/php to newer cimg/php Automattic/wp…

b2e9f99

…comsh#1728

Untangle: add gating for wpcom_classic_early_release blog option Au…

55d8a75

…tomattic/wpcomsh#1714

Bump version to 3.15.0 Automattic/wpcomsh#1730

9061679

jetpack-mu-wpcom: use v5.15.1 Automattic/wpcomsh#1731

752f708

* Use jetpack-mu-wpcom v5.15.0 * wpcomsh bump to 13.15.1 * Use jetpack-mu-wpcom v5.15.1

Untangle: Don't change homepage when switching theme Automattic/wpcom…

ebd300e

…sh#1732

Bump version number to 3.15.2 Automattic/wpcomsh#1734

c446b2d

Detect migrate guru start and call WPCOM API Automattic/wpcomsh#1733

da25971

* initial commit * earliear hook * working prototype * fixes * fix constant * linting + comments * linting * more linting * mooore linting * version bump --------- Co-authored-by: Andrés Blanco <[email protected]>

jetpack-mu-wpcom: use v5.15.2 Automattic/wpcomsh#1735

8fcc204

* Use jetpack-mu-wpcom v5.15.2 * wpcomsh bump to 13.15.4

Updating jetpack-mu-wpcom to version 5.16.0. Automattic/wpcomsh#1736

cea4aa5

* Updating jetpack-mu-wpcom to 5.6.0. * Bump version to 3.16.0.

jetpack-mu-wpcom: use v5.16.1 Automattic/wpcomsh#1737

5a1215e

* Use jetpack-mu-wpcom v5.16.1 * wpcomsh bump to 3.16.1

Update the version for the code deployment endpoint release Automatti…

710a0b4

…c/wpcomsh#1739

Untangle: Re-enable Color Schema on Profile for wp-admin interface Au…

7ba2655

…tomattic/wpcomsh#1669 * Correctly read/update synced color scheme when saving from wp-admin --------- Co-authored-by: Ashar Fuadi <[email protected]>

jetpack-mu-wpcom: use v5.17.0 Automattic/wpcomsh#1741

c4c82e2

* Use jetpack-mu-wpcom v5.17.0 * wpcomsh bump to 3.17.1

Untangle: proxied a12s are no longer auto opted-in Automattic/wpcomsh…

22b61a9

…#1742

Bump version to 3.17.2 Automattic/wpcomsh#1743

ccbd858

Update wc-calypso-bridge to 2.3.11 and wpcomsh to 3.17.3 Automattic/w…

f556236

…pcomsh#1744 * Bump wc-calypso-bridge to 2.3.11 * Bump version to 3.17.3

GitHub Deployments: Remove feature flag call Automattic/wpcomsh#1746

5cd2f99

* GitHub Deployments: Remove feature flag call * Bump WPCOMSH version to 3.17.4

jetpack-mu-wpcom: use v5.18.0 Automattic/wpcomsh#1747

98c3b6d

* Use jetpack-mu-wpcom v5.18.0 * wpcomsh bump to 3.17.5

Jetpack: move away from deprecated Jetpack_Client class Automattic/wp…

69a6b8d

…comsh#1749 * Jetpack: move away from deprecated class Fixes #292 Fixes #399 This class was deprecated years ago. We can now safely move to its replacement. * Bump version

Scheduled Updates: Add menu item for eligible sites Automattic/wpcoms…

fe560fa

…h#1748 * Scheduled Updates: Add menu item for eligible sites * Version bump

jetpack-mu-wpcom: use v5.19.0 Automattic/wpcomsh#1754

3e1d0db

* Use jetpack-mu-wpcom v5.19.0 * Bump wpcomsh

Site Migration: Filter migrations started by migrate guru Automattic/…

150b1e4

…wpcomsh#1753 * Filter migrations started by migrateguru * Bump files * Revert "Bump files" This reverts commit 34cd1f6b665cdb2f47124e29274bea3646e8e022. * Bump

zinigor added 4 commits June 11, 2024 22:01

Un-mangling .po files.

9c06fc1

Temporarily removing the wpcomsh+jetpack combination.

a3469b6

Merge branch 'trunk' into add/converge-wpcomsh

9b65ee7

Added the Jetpack_Mu_Wpcom file to Phan's visibility.

de1f5fe

zinigor enabled auto-merge (squash) June 12, 2024 12:21

anomiex reviewed Jun 12, 2024

View reviewed changes

anomiex disabled auto-merge June 12, 2024 12:44

zinigor and others added 14 commits June 12, 2024 17:27

Update projects/plugins/wpcomsh/bin/create-github-release.sh

7bf4c35

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/composer.json

cb613a2

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/feature-plugins/hooks.php

2d5ff64

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/frontend-notices/gifting-banner/gifti…

73c68fa

…ng-banner.php Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/i18n.php

75daa5e

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/plugin-hotfixes.php

2b46227

Co-authored-by: Brad Jorsch <[email protected]>

Update projects/plugins/wpcomsh/wpcomsh.php

55c6331

Co-authored-by: Brad Jorsch <[email protected]>

Added beta plugin slug, h/t @anomiex.

e79719a

Merge branch 'trunk' into add/converge-wpcomsh

79a3ebb

Updated lockfile.

34dbe5a

Skipping wpcomsh for plugin update tests, h/t @anomiex.

b2ab817

Removed wpcomsh from update test.

1a8f0f1

Revert "Removed wpcomsh from update test."

5b4875c

This reverts commit 1a8f0f1.

Added a check for WPCOM.

0e38e6e

zinigor mentioned this pull request Jun 12, 2024

Added an exception in the plugin update test for wpcomsh. #37825

Merged

3 tasks

Revert "Added a check for WPCOM."

0d115b7

This reverts commit 0e38e6e.

anomiex approved these changes Jun 12, 2024

View reviewed changes

zinigor merged commit 68d1ce7 into trunk Jun 12, 2024
73 checks passed

zinigor deleted the add/converge-wpcomsh branch June 12, 2024 18:31

github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 12, 2024

zinigor mentioned this pull request Jun 13, 2024

Adding a skeleton of wpcomsh to experiment with running tests. #35792

Closed

3 tasks

mreishus mentioned this pull request Sep 18, 2024

Move "composer/installers" package to require-dev. Automattic/wc-calypso-bridge#1513

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing wpcom site helper plugin into the Monorepo. #37737

Introducing wpcom site helper plugin into the Monorepo. #37737

zinigor commented Jun 6, 2024

anomiex left a comment

anomiex commented Jun 12, 2024

Introducing wpcom site helper plugin into the Monorepo. #37737

Introducing wpcom site helper plugin into the Monorepo. #37737

Conversation

zinigor commented Jun 6, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

anomiex left a comment

Choose a reason for hiding this comment

anomiex commented Jun 12, 2024