Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo-gardening: Remove guessing of release dates #38462

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 22, 2024

Proposed changes:

We added this guessing back when Jetpack was the only plugin, and we still did a week-long testing week. That just got carried forward as we added additional plugins and so on.

For Jetpack we should be safe relying on the milestone, it's on the release checklist to create the new milestone. For most of the other plugins, if there's no milestone then we may as well just say there's no scheduled release. The exceptions to that are wpcomsh and mu-wpcom-plugin, which get custom messaging if no milestone exists.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pf4qpu-u1-p2#comment-436

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We added this guessing back when Jetpack was the only plugin, and we
still did a week-long testing week. That just got carried forward as we
added additional plugins and so on.

For Jetpack we should be safe relying on the milestone, it's on the
release checklist to create the new milestone. For most of the other
plugins, if there's no milestone then we may as well just say there's no
scheduled release. The exceptions to that are wpcomsh and
mu-wpcom-plugin, which get custom messaging if no milestone exists.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Pri] Normal labels Jul 22, 2024
@anomiex anomiex self-assigned this Jul 22, 2024
@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels Jul 22, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

anomiex added a commit that referenced this pull request Jul 22, 2024
anomiex added a commit that referenced this pull request Jul 22, 2024
@anomiex anomiex requested review from a team and jeherve July 22, 2024 19:25
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jul 22, 2024
@anomiex anomiex enabled auto-merge (squash) July 22, 2024 19:25
@anomiex anomiex merged commit 469b214 into trunk Jul 23, 2024
55 checks passed
@anomiex anomiex deleted the remove/gardening-guessing-of-release-dates branch July 23, 2024 11:56
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants