Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo-gardening: Remove guessing of release dates #38462

Merged
merged 2 commits into from
Jul 23, 2024
Merged

repo-gardening: Remove guessing of release dates #38462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e56b591
repo-gardening: Remove guessing of release dates
anomiex Jul 22, 2024
d45abc5
Correct name for mu-wpcom plugin
anomiex Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/github-actions/repo-gardening/changelog/remove-gardening-guessing-of-release-dates
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: removed

Check description task: Remove general guessing of release dates and code freezes. Add special casing for wpcomsh and mu-wpcom-plugin.
21 changes: 6 additions & 15 deletions projects/github-actions/repo-gardening/src/tasks/check-description/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ async function hasProgressLabel( octokit, owner, repo, number ) {
* @returns {Promise<string>} Promise resolving to info about the release (code freeze, release date).
*/
async function getMilestoneDates( plugin, nextMilestone ) {
let releaseDate;
let releaseDate = 'none scheduled';
let codeFreezeDate;
if ( nextMilestone && nextMilestone.hasOwnProperty( 'due_on' ) && nextMilestone.due_on ) {
releaseDate = moment( nextMilestone.due_on ).format( 'LL' );
Expand All @@ -77,19 +77,11 @@ async function getMilestoneDates( plugin, nextMilestone ) {
// If we have a date and it is valid, use it, otherwise set code freeze to a week before the release.
if ( freezeDateDescription && moment( freezeDateDescription[ 1 ] ).isValid() ) {
codeFreezeDate = moment( freezeDateDescription[ 1 ] ).format( 'LL' );
} else {
codeFreezeDate = moment( nextMilestone.due_on ).subtract( 7, 'd' ).format( 'LL' );
}
} else {
// Fallback to raw math calculation
// Calculate next release date
const firstTuesdayOfMonth = moment().add( 1, 'months' ).startOf( 'month' );
while ( firstTuesdayOfMonth.day() !== 2 ) {
firstTuesdayOfMonth.add( 1, 'day' );
}
releaseDate = firstTuesdayOfMonth.format( 'LL' );
// Calculate next code freeze date
codeFreezeDate = firstTuesdayOfMonth.subtract( 8, 'd' ).format( 'LL' );
} else if ( plugin === 'wpcomsh' ) {
releaseDate = 'on demand (usually Mondays if not sooner)';
} else if ( plugin === 'mu-wpcom' ) {
releaseDate = 'WordPress.com Simple releases happen daily';
}

const capitalizedName = plugin
Expand All @@ -113,8 +105,7 @@ ${
- Releases to self-hosted sites happen monthly. The next release is scheduled for _${ releaseDate }_ (scheduled code freeze on _${ codeFreezeDate }_).`
: `
- Next scheduled release: _${ releaseDate }_.
- Scheduled code freeze: _${ codeFreezeDate }_.
`
${ codeFreezeDate ? `- Scheduled code freeze: _${ codeFreezeDate }_.\n` : '' }`
}

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Expand Down