Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toolbar proxy notice for Atomic sites #38519

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jul 24, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7622

Proposed changes:

  • This PR adds a notice in profile.php for a12ns informing them that the Toolbar is always visible on Atomic sites when connected to the a8c proxy. This is due to the debug-bar-loader plugin forcing the toolbar to be enabled. p1714985574878659-slack-C7YPW6K40
  • The message shown below is visible when proxied on Atomic sites.
No proxy & Simple sites Proxied Atomic sites
Screenshot 2024-07-24 at 3 55 45 PM Screenshot 2024-07-24 at 3 55 32 PM

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No.

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Load this PR using the instructions below.
  • On your test Atomic site go to /wp-admin/profile.php while connected to the proxy. You should see the notice mentioned above.
  • Disconnect from the proxy and refresh the page. The notice should not be visible.
  • On a test Classic Simple site, go to /wp-admin/profile.php while connected to the proxy. You should NOT see the notice because Simple sites do not load the debug-bar-loader plugin, so we do not need to show it, as the toolbar works as expected.

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/profile-toolbar-notice branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/profile-toolbar-notice
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 24, 2024
@DustyReagan DustyReagan self-assigned this Jul 24, 2024
@DustyReagan DustyReagan added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 24, 2024
@DustyReagan DustyReagan requested review from a team July 24, 2024 21:08
@DustyReagan DustyReagan changed the title Add/profile toolbar notice Add Toolbar proxy notice for Atomic sites Jul 24, 2024
Copy link
Contributor

@lupus2k lupus2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not proxied
image

Proxied
image

@DustyReagan DustyReagan merged commit 5fc4449 into trunk Jul 24, 2024
54 checks passed
@DustyReagan DustyReagan deleted the add/profile-toolbar-notice branch July 24, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants