Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing block: remove check for existing block in post content #38727

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 6, 2024

Proposed changes:

This is no longer necessary after some improvements to the Block Hooks API.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a site that's connected to WordPress.com, using a block-based theme, and where the Sharing module is not active.
  • Enable auto-addition of the sharing block to single post templates: wp option update jetpack_sharing_buttons_auto_add 1
  • Visit a single post ; you should see sharing buttons being added at the bottom of the post.
  • Now go to Appearance > Editor > Templates > Single Posts
  • Add a sharing block and configure it, right below the post title for example.
  • Remove any sharing block you may see at the bottom of the post content.
  • Save your changes.
  • Now visit a single post again ; you should only see the new sharing block you added to the top of the template, under the post title.

This is no longer necessary after some improvements to the Block Hooks API.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Focus] Performance [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Block] Sharing Buttons [Block] Sharing Button labels Aug 6, 2024
@jeherve jeherve self-assigned this Aug 6, 2024
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/sharing-block-check-content branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/sharing-block-check-content
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 👍

@coder-karen coder-karen added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 20, 2024
@jeherve jeherve merged commit e59270f into trunk Aug 20, 2024
58 checks passed
@jeherve jeherve deleted the update/sharing-block-check-content branch August 20, 2024 14:25
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 20, 2024
@github-actions github-actions bot added this to the jetpack/13.8 milestone Aug 20, 2024
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
This is no longer necessary after some improvements to the Block Hooks API.
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
This is no longer necessary after some improvements to the Block Hooks API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing Post sharing, sharing buttons [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants