Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing block: remove check for existing block in post content #38727

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Sharing block: remove check for existing block in post content #38727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d6c374
Sharing block: remove check for existing block in post content
jeherve Aug 6, 2024
9226293
Merge remote-tracking branch 'origin/trunk' into update/sharing-block…
jeherve Aug 7, 2024
a598ae1
Merge remote-tracking branch 'origin/trunk' into update/sharing-block…
jeherve Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-sharing-block-check-content
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: compat

Sharing Block: improve performance when hooking the block into single post templates.
6 changes: 0 additions & 6 deletions projects/plugins/jetpack/extensions/blocks/sharing-button/sharing-button.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,6 @@ function add_block_to_single_posts_template( $hooked_block_types, $relative_posi
return $hooked_block_types;
}

$content = $context->content ?? '';
// Check if the block is already in the template. If so, abort.
if ( false !== strpos( $content, 'wp:' . PARENT_BLOCK_NAME ) ) {
return $hooked_block_types;
}

$hooked_block_types[] = PARENT_BLOCK_NAME;
return $hooked_block_types;
}
Expand Down
Loading