Social | Initial State: Migrate URLs

[manzoorwanijk]

As a part of consolidating our initial state started in #38606, we need to migrate the way we pass/compute the URLs that we need in Social JS code

Proposed changes:

• Add urls to the social script data (initial state)
• Use those URLs in place of existing ones
• Remove the unused URLs
• Update some URLs to use the client-side utility functions to generate the URLs

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Test the following on Jetpack, Simple and Atomic sites

• Go to editor
• Simulate some broken connections
• Confirm that the fix link in broken connection notice works as expected
• When there is no user connection
  • Confirm that the "Connect now" link in the editor points to the correct URL
  • Confirm that the connect user account link on Social admin page works as expected
• Confirm that the "Manage connections" link/butotn in the editor works as expected
• On social admin page, when a new plan is purchased without activating it, confirm that the licence activation link points to the correct location
• On social admin page, confirm that "Write a post" and "Create a note" links point to the correct location. Also confirm that the "Connect accounts" link/button works as expected.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-initial-state/migrate-urls branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/social-initial-state/migrate-urls
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-initial-state/migrate-urls
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

• Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[gmjuhasz]

Tested on a JN site and worked well! Just had a minor thought

[gmjuhasz]

Should we do destructing for both or neither?

[manzoorwanijk]

I left urls like that to maintain the context when the variable is used, i.e. urls.connectionsManagementPage conveys more information than just connectionsManagementPage