Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Fix incorrectly quoted * in bash scripts #39121

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Aug 28, 2024

Proposed changes:

In a few places, we do something like [[ "$var" == "*/filename" ]], which checks for the variable being literally "*/filename" rather than interpreting the * as a glob as intended.

This removes the unnecessary quotes so it works right.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try running something like tools/composer-update-monorepo.sh projects/plugins/beta/composer.lock or tools/version-packages.sh projects/plugins/beta/composer.json, see if it works right rather than complaining that the directory doesn't exist.

In a few places, we do something like `[[ "$var" == "*/filename" ]]`,
which checks for the variable being literally "*/filename" rather than
interpreting the `*` as a glob as intended.

This removes the unnecessary quotes so it works right.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Aug 28, 2024
@anomiex anomiex requested a review from a team August 28, 2024 14:21
@anomiex anomiex self-assigned this Aug 28, 2024
@anomiex anomiex enabled auto-merge (squash) August 28, 2024 14:21
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@anomiex anomiex merged commit 7801b7f into trunk Aug 29, 2024
56 checks passed
@anomiex anomiex deleted the fix/tools-incorrectly-quoted-bash-star branch August 29, 2024 11:32
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 29, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
In a few places, we do something like `[[ "$var" == "*/filename" ]]`,
which checks for the variable being literally "*/filename" rather than
interpreting the `*` as a glob as intended.

This removes the unnecessary quotes so it works right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants