-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible Plugins: removes duplicator pro. #39775
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Hi @cpapazoglou I'm Andrea, the lead of the Duplicator project. I would like to make a small clarification: the LITE and PRO versions of Duplicator are fundamentally different. The PRO version is more advanced and manages dynamic custom folders, along with many other features that make it compatible with wp.com. For the moment, we have focused on resolving the issues related to the PRO version to restore its compatibility. I was unable to replicate the problem with wp-cli, but I have made some changes that generally improve the boot process when executing a wp-cli command. Additionally, I have disabled the ability to import backups created on other websites when operating on wp.com. These two changes should resolve all potential issues related to the PRO version. If needed, I would be happy to send you the PRO version of the plugin for further testing. I remain at your disposal for any clarifications or further needs. Thank you again for your contribution. |
Hey @andreamk
Noted.
Can you share the latest version with me? You can email me a link at [email protected].
Hmm. This sounds like disabling the most used feature? Like, when a site migrates to WP.com from another hosting?
does this apply only to the non-pro version? |
Hi @cpapazoglou
Done, thanks
The most commonly used feature is backup management and restoration, while importing from external sites to wp.com presents significant complexities. For example, Duplicator needs to merge the user tables between the source and target sites. These are implemented and working processes, but for now, we prefer to have Duplicator Pro enabled on WP.COM. Then, at a later stage, we will restore the rest once we are sure everything is working as it should.
Yes, exactly. The PRO version can handle any type of custom PATH structure, while the LITE version has a much simpler logic and bases backup generation on the ABSPATH root. Making the LITE version compatible with WP.COM is planned, but it requires more work. |
Hey @andreamk, thanks for the zip file. I ran some tests:
|
313f746
to
5f88400
Compare
Hi @cpapazoglou
Perfect!
We conducted tests on our staging site on WordPress.com and did not need to enable this option. You may have some restrictions on your test site, but everything worked correctly on our end. If you believe it’s necessary, we can investigate further.
Great!
Yes, in our backups, the core WordPress files are also included, but the installer is designed so that if extracting a file fails, the entire installation does not fail. For this reason, there are all those warnings, which have no impact on the final result. I am planning a patch to prevent writing to WordPress.com, in order to improve user feedback. Thank you very much for your considerations and your help. |
5f88400
to
e7451b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since blocker issues related to @andreamk let us know if issues related to |
This PR is a collection of changes needed to enable
duplicator
andduplicator-pro
installations in WordPress.com.Related discussion p1728637897603379-slack-C07QQD54LKU
WordPress.com Team
Duplicator Team
duplicator-pro
breakswp-cli
commands in WordPress.com.wp_users
table. Solved with a workaroundduplicator
usesABSPATH
to define the location of thewp-content
directory ( or other directories ).can be modified to
When extracting/installing the duplicated site, the default filename that the plugin generates is named
installer.php
and must be uploaded and then accessed directly via URL to complete the install process. This filename is blocked for security reasons by Atomic and will return a 403 Forbidden error when you attempt to access it. This can default to anything else such asduplicator.php
orinstall.php
and then the file will be accessible.Nice to have - Backups tend to fill storage quickly if you make multiple backups or scheduled backups. It would be cool educating the user about storage implications of multiple backups.
Proposed changes:
duplicator-pro
to be installed in WordPress.com.duplicator
was not deemed as a priority for now.Testing instructions:
The following are related to the changes introduced from this PR, not related to whether all
duplicator
issues are fixed.jetpack/projects/plugins/wpcomsh/README.md
Lines 1 to 328 in 5d37c1f
duplicator-pro
plugin ( ping me for the zip )Does this pull request change what data or activity we track or use?
No