Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synced Newspack Blocks: Update to 4.5.2 #40636
Synced Newspack Blocks: Update to 4.5.2 #40636
Changes from 15 commits
f8fb1e9
73e653f
7520915
26ed945
f51d4b3
e385469
58c59a2
428a09d
c1caf91
de03fc9
3af28b0
bdee6ad
307bbd4
f334dbe
0b0dba3
ba51ed5
83b0491
3135249
ed996dd
de0c564
c354232
877a79d
38dafc1
8465bfc
5d3d690
2f56f6b
bc7ac12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want you could source the file from the monorepo root
tools/includes/proceed_p.sh
to use our fancy function for doing prompts like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any advantage of sourcing vs a simple
read
? :^)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
proceed_p
function handles a bunch of edge cases. It doesn't matter a whole lot though. 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me:
That said, it'll only detect files directly in said folder.
Either way, it should soon be a non-issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further thought, no need to wait to remove this: bc7ac12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this be a bunch of noise, since it doesn't actually check if
ENT_COMPAT
is already in use?Ideally we'd let
PHPCompatibility.ParameterValues.NewHTMLEntitiesFlagsDefault
detect it, but first they'd have to release a version of PHPCompatibility that contains that rule. 🙁OTOH, will the
.phpcsignore
take care of ignoring that too during the CI run? Is that the only reason this is here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, it's only ever been one line to change, so I don't think it's too much noise. It's in there because the README said it was important to check for, and I figured it'd be helpful to point out places to check vs. assume the user knows what to look for. 🤷
Yeah, the synced folder will be ignored by CI, so it's a manual fix we need to be aware of (though I'm open to alternatives).
That said, I wonder if this is an issue upstream too, at which point a patch there would remove the need to fix it here... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if it needs fixing, the fix really should be upstreamed.
The consequences of not fixing it are that behavior will differ depending on the PHP version, PHP <8.1 vs 8.1+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put in a PR upstream: Automattic/newspack-blocks#2010
Once that's merged, I'll remove that task from the script/README. :^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed now instead of waiting: bc7ac12