Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using actualColor.background to change background #689

Merged
merged 1 commit into from
May 22, 2021

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented May 21, 2021

Originally spotted in #634 and fixed in a temporary branch as indicated in #634 (comment) (see section Smoke test), cherry picked the commit here to make background color selection for text work again on the color picker.

Before:
Screenshot_20210521-111109

After:
Screenshot_20210521-111443

@mzorz mzorz requested a review from aforcier May 21, 2021 09:16
Copy link
Collaborator

@aforcier aforcier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aforcier aforcier merged commit 7d89acd into feature/view-binding May 22, 2021
@aforcier aforcier deleted the view-binding/fix-text-color branch May 22, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants