Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using actualColor.background to change background #689

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix: using actualColor.background to change background #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stories/src/main/java/com/wordpress/stories/compose/text/TextColorPickerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TextColorPickerAdapter internal constructor(private val context: Context,
private var selectedPosition = colorPickerColors.indexOf(startColor)

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder {
return ViewHolder(ColorPickerListItemBinding.inflate(LayoutInflater.from(context)))
return ViewHolder(ColorPickerListItemBinding.inflate(LayoutInflater.from(parent.context), parent, false))
}

override fun onBindViewHolder(holder: ViewHolder, position: Int) {
Expand All @@ -34,7 +34,7 @@ class TextColorPickerAdapter internal constructor(private val context: Context,
holder.binding.colorPickerSelectedCheckmarkView.visibility = View.GONE
} else {
holder.binding.colorPickerViewActualColor.setBackgroundResource(R.drawable.ic_color_picker_filler)
val background = holder.binding.colorPickerSelectedCheckmarkView.background
val background = holder.binding.colorPickerViewActualColor.background
if (background is GradientDrawable) {
background.setColor(colorPickerColors[position])
} else if (background is ColorDrawable) {
Expand Down