Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional check and fix button deprecated parameters #1527

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Oct 2, 2024

Changes proposed in this Pull Request:

Closes #1525.

  • Silences JS error by adding optional check
  • Fixes deprecated parameter for button component by replacing it with variant parameter
image

How to test the changes in this Pull Request:

  1. Ensure your site has no published product (optionally, trash them temporarily)
  2. Open JS console
  3. Go to Homescreen
  4. Complete Customize your store task if it's not yet completed
  5. Observe product task header loads correctly (title, description, CTA button)
  6. Observe no undefined error in JS console

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested review from a team, chihsuan and moon0326 October 2, 2024 08:42
Copy link

github-actions bot commented Oct 2, 2024

Size Change: +18 B (+0.01%)

Total Size: 201 kB

Filename Size Change
./build/index.js 126 kB +18 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./build/53.js 1.08 kB
./build/index.css 731 B
./build/marketing.js 58.3 kB
./build/payment-gateway-suggestions.css 1.24 kB
./build/payment-gateway-suggestions.js 6.57 kB
./build/plugins.js 3.93 kB
./build/style-index.css 2.15 kB
./build/style-marketing.css 800 B

compressed-size-action

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! 🚢

@ilyasfoo ilyasfoo merged commit 8128187 into master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-fatal JS error in product task header component
2 participants