-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Variations: Filter out the colors and fonts #97795
Style Variations: Filter out the colors and fonts #97795
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~26 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~183 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1939 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
f0c6588
to
c5b3ed2
Compare
isVariationWithProperties( variation, [ 'color' ] ); | ||
|
||
const isFontVariation = ( variation: GlobalStylesObject ) => | ||
isVariationWithProperties( variation, [ 'typography' ] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align with TypographyVariations in the Gutenberg.
}; | ||
|
||
const isColorVariation = ( variation: GlobalStylesObject ) => | ||
isVariationWithProperties( variation, [ 'color' ] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align with ColorVariations in the Gutenberg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested TT5 and other themes.
I think my comment above is not a blocker.
Looks like we have to remove badges there. See #93931 If not, we may not be able to filter out colors & fonts there since style variations from themes endpoint are just colors variations (we just return the required data for rendering badges...) |
This reverts commit 7b4af68.
Related to #97134
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist