Feature/compilo vm #101
Tests.yml
on: pull_request
check_compilation
2m 9s
check_style
9s
run_tests
3m 41s
Annotations
6 errors and 16 warnings
check_style
HLint failed with status: 1. Warning (7), Suggestion (24)
|
run_tests:
LobsterLang/test/VmSpec.hs#L22
Data constructor not in scope: Subtract :: Operator
|
run_tests:
LobsterLang/test/VmSpec.hs#L24
Data constructor not in scope: Multiply :: Operator
|
run_tests:
LobsterLang/test/VmSpec.hs#L26
Data constructor not in scope: Divide :: Operator
|
run_tests:
LobsterLang/test/VmSpec.hs#L28
Data constructor not in scope: Divide :: Operator
|
run_tests
Process completed with exit code 2.
|
check_style:
LobsterLang/src/CompiletoVm.hs#L83
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]"
|
check_style:
LobsterLang/src/CompiletoVm.hs#L83
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "[Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
check_style:
LobsterLang/src/CompiletoVm.hs#L99
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
check_style:
LobsterLang/src/CompiletoVm.hs#L113
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "inst\n ++\n (fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))" ▫︎ Perhaps: "inst\n ++\n fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])"
|
check_style:
LobsterLang/src/Parse.hs#L51
Suggestion in Parser in module Parse: Use newtype instead of data ▫︎ Found: "data Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Perhaps: "newtype Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Note: decreases laziness
|
check_style:
LobsterLang/src/Parse.hs#L212
Warning in parseElem in module Parse: Use const ▫︎ Found: "\\ x _ -> x" ▫︎ Perhaps: "const"
|
check_style:
LobsterLang/src/Parse.hs#L309
Suggestion in parseListElem in module Parse: Redundant bracket ▫︎ Found: "case (parseOthers parser pos' s') of\n Left err -> Left err\n Right (res', s'', pos'') -> Right (res : res', s'', pos'')" ▫︎ Perhaps: "case parseOthers parser pos' s' of\n Left err -> Left err\n Right (res', s'', pos'') -> Right (res : res', s'', pos'')"
|
check_style:
LobsterLang/src/Parse.hs#L317
Suggestion in parseListElem in module Parse: Redundant bracket ▫︎ Found: "case (parseOthers parser pos'' s'') of\n Left err -> Left err\n Right (res', s''', pos''') -> Right (res : res', s''', pos''')" ▫︎ Perhaps: "case parseOthers parser pos'' s'' of\n Left err -> Left err\n Right (res', s''', pos''') -> Right (res : res', s''', pos''')"
|
check_style:
LobsterLang/src/Parse.hs#L421
Suggestion in parseDefineFn in module Parse: Redundant bracket ▫︎ Found: "parseCmpString \"fn\" *> (Parser defineFn)" ▫︎ Perhaps: "parseCmpString \"fn\" *> Parser defineFn"
|
check_style:
LobsterLang/src/Parse.hs#L460
Suggestion in parseCond in module Parse: Redundant bracket ▫︎ Found: "((AST.Cond res res' Nothing), s'', pos'')" ▫︎ Perhaps: "(AST.Cond res res' Nothing, s'', pos'')"
|
run_tests:
LobsterLang/test/AstEvalSpec.hs#L1
The export item ‘module AstEvalSpec’ is missing an export list
|
run_tests:
LobsterLang/test/AstOptimizerSpec.hs#L1
The export item ‘module AstOptimizerSpec’ is missing an export list
|
run_tests:
LobsterLang/test/CompilerSpec.hs#L1
The export item ‘module CompilerSpec’ is missing an export list
|
run_tests:
LobsterLang/test/CompilerSpec.hs#L11
The import of ‘Data.Maybe’ is redundant
|
run_tests:
LobsterLang/test/ParserSpec.hs#L1
The export item ‘module ParserSpec’ is missing an export list
|
run_tests:
LobsterLang/test/ParserSpec.hs#L12
The import of ‘Parse’ is redundant
|