Feature/compilo vm #101
Annotations
1 error and 10 warnings
|
Run HLint
HLint failed with status: 1. Warning (7), Suggestion (24)
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L83
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L83
Suggestion in convert in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.PushList (fromIntegral (lenList :: Int32) :: Int))]" ▫︎ Perhaps: "[Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L99
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
|
|
Run HLint:
LobsterLang/src/CompiletoVm.hs#L113
Suggestion in getList in module CompiletoVm: Redundant bracket ▫︎ Found: "inst\n ++\n (fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))" ▫︎ Perhaps: "inst\n ++\n fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L51
Suggestion in Parser in module Parse: Use newtype instead of data ▫︎ Found: "data Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Perhaps: "newtype Parser a\n = Parser {runParser :: Position\n -> String -> Either String (a, String, Position)}" ▫︎ Note: decreases laziness
|
|
Run HLint:
LobsterLang/src/Parse.hs#L212
Warning in parseElem in module Parse: Use const ▫︎ Found: "\\ x _ -> x" ▫︎ Perhaps: "const"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L309
Suggestion in parseListElem in module Parse: Redundant bracket ▫︎ Found: "case (parseOthers parser pos' s') of\n Left err -> Left err\n Right (res', s'', pos'') -> Right (res : res', s'', pos'')" ▫︎ Perhaps: "case parseOthers parser pos' s' of\n Left err -> Left err\n Right (res', s'', pos'') -> Right (res : res', s'', pos'')"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L317
Suggestion in parseListElem in module Parse: Redundant bracket ▫︎ Found: "case (parseOthers parser pos'' s'') of\n Left err -> Left err\n Right (res', s''', pos''') -> Right (res : res', s''', pos''')" ▫︎ Perhaps: "case parseOthers parser pos'' s'' of\n Left err -> Left err\n Right (res', s''', pos''') -> Right (res : res', s''', pos''')"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L421
Suggestion in parseDefineFn in module Parse: Redundant bracket ▫︎ Found: "parseCmpString \"fn\" *> (Parser defineFn)" ▫︎ Perhaps: "parseCmpString \"fn\" *> Parser defineFn"
|
|
Run HLint:
LobsterLang/src/Parse.hs#L460
Suggestion in parseCond in module Parse: Redundant bracket ▫︎ Found: "((AST.Cond res res' Nothing), s'', pos'')" ▫︎ Perhaps: "(AST.Cond res res' Nothing, s'', pos'')"
|
The logs for this run have expired and are no longer available.
Loading