Skip to content

Clean code

Clean code #145

Triggered via pull request February 11, 2024 15:19
Status Success
Total duration 4m 53s
Artifacts

Tests.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

19 warnings
check_style
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check_style: LobsterLang/src/CompiletoVm.hs#L107
Suggestion in getFnv in module CompiletoVm: Redundant bracket ▫︎ Found: "case\n (decodeOrFail byteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\nof\n Left _ -> (inst, byteString)\n Right (nByteString, _, val)\n -> (getFnv\n 0 byteStringAfterInst\n (inst\n ++\n [Vm.Push\n (Vm.Function\n functionInstruction (fromIntegral (val :: Int32) :: Int))]))\n where\n nbinstruction\n = case\n (decodeOrFail nByteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\n of\n Left _ -> 0\n Right (_, _, valu) -> (fromIntegral (valu :: Int32) :: Int)\n byteStringafterNbInst\n = case\n (decodeOrFail nByteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\n of\n Left _ -> nByteString\n Right (afterNbInst, _, _) -> afterNbInst\n functionInstruction\n = fst (getInstructionFunc nbinstruction byteStringafterNbInst [])\n byteStringAfterInst\n = snd (getInstructionFunc nbinstruction byteStringafterNbInst [])" ▫︎ Perhaps: "case\n (decodeOrFail byteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\nof\n Left _ -> (inst, byteString)\n Right (nByteString, _, val)\n -> getFnv\n 0 byteStringAfterInst\n (inst\n ++\n [Vm.Push\n (Vm.Function\n functionInstruction (fromIntegral (val :: Int32) :: Int))])\n where\n nbinstruction\n = case\n (decodeOrFail nByteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\n of\n Left _ -> 0\n Right (_, _, valu) -> (fromIntegral (valu :: Int32) :: Int)\n byteStringafterNbInst\n = case\n (decodeOrFail nByteString ::\n Either (BIN.ByteString, ByteOffset, String) (BIN.ByteString,\n ByteOffset, Int32))\n of\n Left _ -> nByteString\n Right (afterNbInst, _, _) -> afterNbInst\n functionInstruction\n = fst (getInstructionFunc nbinstruction byteStringafterNbInst [])\n byteStringAfterInst\n = snd (getInstructionFunc nbinstruction byteStringafterNbInst [])"
check_style: LobsterLang/src/CompiletoVm.hs#L127
Suggestion in getArg in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
check_style: LobsterLang/src/CompiletoVm.hs#L141
Suggestion in getArg in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
check_style: LobsterLang/src/CompiletoVm.hs#L146
Suggestion in getArg in module CompiletoVm: Use record patterns ▫︎ Found: "Compiler.Fnv _ _ _ _ _ _" ▫︎ Perhaps: "Compiler.Fnv {}"
check_style: LobsterLang/src/CompiletoVm.hs#L146
Suggestion in getArg in module CompiletoVm: Redundant bracket ▫︎ Found: "inst ++ (fst (getFnv (- 1) remainingfile []))" ▫︎ Perhaps: "inst ++ fst (getFnv (- 1) remainingfile [])"
check_style: LobsterLang/src/CompiletoVm.hs#L156
Suggestion in getInstructionFunc in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
check_style: LobsterLang/src/CompiletoVm.hs#L170
Suggestion in getInstructionFunc in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
check_style: LobsterLang/src/CompiletoVm.hs#L201
Suggestion in getInstructionFunc in module CompiletoVm: Redundant bracket ▫︎ Found: "inst ++ (fst (getFnv (- 1) remainingfile []))" ▫︎ Perhaps: "inst ++ fst (getFnv (- 1) remainingfile [])"
check_style: LobsterLang/src/CompiletoVm.hs#L212
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "[(Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int)))]" ▫︎ Perhaps: "[Vm.Push (IntVal (fromIntegral (val :: Int32) :: Int))]"
check_style: LobsterLang/src/CompiletoVm.hs#L226
Suggestion in getDefinedValue in module CompiletoVm: Redundant bracket ▫︎ Found: "(fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile []))\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]" ▫︎ Perhaps: "fst (getList (fromIntegral (lenList :: Int32) :: Int) remfile [])\n ++ [Vm.PushList (fromIntegral (lenList :: Int32) :: Int)]"
check_compilation
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, haskell-actions/setup@v2, andstor/file-existence-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
run_tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, haskell-actions/setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
run_tests: LobsterLang/test/AstEvalSpec.hs#L1
The export item ‘module AstEvalSpec’ is missing an export list
run_tests: LobsterLang/test/AstOptimizerSpec.hs#L1
The export item ‘module AstOptimizerSpec’ is missing an export list
run_tests: LobsterLang/test/CompilerSpec.hs#L1
The export item ‘module CompilerSpec’ is missing an export list
run_tests: LobsterLang/test/CompilerSpec.hs#L11
The import of ‘Data.Maybe’ is redundant
run_tests: LobsterLang/test/ParserSpec.hs#L1
The export item ‘module ParserSpec’ is missing an export list
run_tests: LobsterLang/test/VmSpec.hs#L1
The export item ‘module VmSpec’ is missing an export list