-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMEA Messages on Android #932
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 94.11% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
===========================================
+ Coverage 94.11% 100.00% +5.88%
===========================================
Files 5 20 +15
Lines 221 448 +227
===========================================
+ Hits 208 448 +240
+ Misses 13 0 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I have tested this feature and it's working very well. I think in pubspec.yaml should be:
|
Update Main
Bring Nmea changes inline with recent updates to plugin
Hi @mvanbeusekom, I'm not sure what your plans are with NMEA message streaming in this plugin, but I cleaned up this PR and brought it back up to date with the main branch in hopes in might get merged or helps your other development plans. Please let me know if there is anything else I can do to help! |
Hey @mvanbeusekom, I brought this PR back in line with main and targeted the latest release of the baseflow_plugin_template to get around the deprecation errors, but wondering if you would like me to separate this into multiple PRs or if the internal dependency overrides can just be removed before this possibly gets merged? |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Adds ability to listen to NMEA messages on Android.
📝 Links to relevant issues/docs
Closes #561, closes #605, closes #819
This builds upon #605 and #819 using the updated project structure. I understand that @mvanbeusekom is working on a different approach, but this may function as a workaround for now. Until this is merged, you will need to include this in your project's
pubspec.yaml
:🤔 Checklist before submitting
main
.